Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid analyzing generated configuration file #2135

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

henrymercer
Copy link
Contributor

Store the generated config file in temporary directory to prevent it from becoming part of the analysis.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

This prevents it from becoming part of the analysis.
@henrymercer henrymercer requested a review from a team as a code owner February 13, 2024 16:00
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, though do we expect the config file to affect the analysis in some way if it's not in the temp directory?

@henrymercer
Copy link
Contributor Author

henrymercer commented Feb 13, 2024

Since it's a YAML file it'll be included in JavaScript extraction by default. I noticed when I was trying to create a "no code found" error, but despite no JS or YAML being in the repository, the JavaScript analysis successfully extracted the configuration file and therefore didn't error.

@henrymercer henrymercer merged commit bc64d12 into main Feb 13, 2024
295 checks passed
@henrymercer henrymercer deleted the henrymercer/no-analyze-config branch February 13, 2024 18:32
@github-actions github-actions bot mentioned this pull request Feb 15, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants