Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to macos-13 runners #2577

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Move to macos-13 runners #2577

merged 4 commits into from
Nov 8, 2024

Conversation

aeisenberg
Copy link
Contributor

Macos-12 runners are deprecated and are refusing to run.

See some of the failures like this one: https://github.com/github/codeql-action/actions/runs/11671821941/job/32499094199?pr=2575

@cklin
Copy link
Contributor

cklin commented Nov 4, 2024

I think we need to update .github/workflows/codeql.yml too.

Macos-12 runners are deprecated and are refusing to run.
@aeisenberg
Copy link
Contributor Author

Since I removed some checks, the status won't be ready to merge until I update the checks.

@aeisenberg aeisenberg force-pushed the aeisenberg/macos-13-runners branch 4 times, most recently from 2cac9f7 to b9d17bd Compare November 7, 2024 22:55
@aeisenberg aeisenberg marked this pull request as ready for review November 8, 2024 00:12
@aeisenberg aeisenberg requested a review from a team as a code owner November 8, 2024 00:12
@aeisenberg
Copy link
Contributor Author

This was a lot trickier to get working that I was expecting. I think it should pass now. I will update the required checks afterwards.

@henrymercer
Copy link
Contributor

#2588 fixes the export file baseline test.

@aeisenberg aeisenberg changed the base branch from main to henrymercer/fix-export-test November 8, 2024 17:54
Base automatically changed from henrymercer/fix-export-test to main November 8, 2024 17:54
@aeisenberg
Copy link
Contributor Author

Rebasing in order to get a fix for Export file baseline information tests.

Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Andrew!

@aeisenberg aeisenberg merged commit acb9cb1 into main Nov 8, 2024
271 checks passed
@aeisenberg aeisenberg deleted the aeisenberg/macos-13-runners branch November 8, 2024 19:25
@aeisenberg
Copy link
Contributor Author

I can now update the required checks and get this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants