Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code so "@typescript-eslint/no-unused-vars" passes #364

Merged
merged 3 commits into from
Jan 18, 2021
Merged

Update code so "@typescript-eslint/no-unused-vars" passes #364

merged 3 commits into from
Jan 18, 2021

Conversation

ericcornelissen
Copy link
Contributor

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

Closes #192, by enabling the @typescript-eslint/no-unused-vars option for ESLint and removing the only remaining unused variables in src/config-utils.test.ts.

robertbrignull
robertbrignull approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Interestingly I thought I'd already seen this set of parameters get removed, but I can't find any other PRs that I might have been thinking of 🤷

@robertbrignull robertbrignull merged commit b0adc41 into github:main Jan 18, 2021
@github-actions github-actions bot mentioned this pull request Jan 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertbrignull robertbrignull robertbrignull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ESLint transition: update code so "@typescript-eslint/no-unused-vars" passes
2 participants
@ericcornelissen @robertbrignull