Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ref input #904

Merged
merged 16 commits into from
Feb 2, 2022
Merged

Add ref input #904

merged 16 commits into from
Feb 2, 2022

Conversation

cw-alexcroteau
Copy link
Contributor

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

See #889, which was closed by mistake.

aeisenberg and others added 15 commits January 31, 2022 16:11
@aeisenberg
Add a permissions block for generated workflows
e9aa2c6 
Ensure that all workflows are able to write security events.
@cw-alexcroteau
Adds ref and SHA as inputs, and sarif-id as output
980fd4e
@cw-alexcroteau @aeisenberg
Apply documentation suggestions from code review
0dd4dbf 
Co-authored-by: Andrew Eisenberg <[email protected]>
@cw-alexcroteau
Applies recomendation in upload-sarif/action.yml
5916f98
@cw-alexcroteau
Adds check on inputs and compiled files
1eaaf07
@cw-alexcroteau
Adds integration test and fixes linting
1bfa9ac
@cw-alexcroteau
Fixes integration test
260b4d5
@cw-alexcroteau
Updates javascript files
3cc8799
@cw-alexcroteau
Fixes integration tests referred repo
63d0c78
@cw-alexcroteau
Changes to commit hash in main branch
dfe2bc4
@cw-alexcroteau
Splits integration tests
9f36b75
@cw-alexcroteau
Regenerates test workflows
72f9a88
@aeisenberg
Merge branch 'aeisenberg/permissions' into add-ref-input
13f97c8
@aeisenberg
Update the description of new inputs
6c6b8c3 
These new inputs will not work on pull requests from forks.
@cw-alexcroteau
Merge pull request #3 from aeisenberg/aeisenberg/add-ref-input
9bfa05f 
Update the description of new inputs
@cw-alexcroteau cw-alexcroteau requested a review from a team as a code owner February 2, 2022 01:28
@cw-alexcroteau cw-alexcroteau mentioned this pull request Feb 2, 2022
Closed
3 tasks
aeisenberg
aeisenberg approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The security-events: write block should have been removed, but looks like it was merged back in. I will remove the block in a follow-up PR.

@aeisenberg aeisenberg merged commit 7719458 into github:main Feb 2, 2022
@cannist cannist mentioned this pull request Feb 3, 2022
Merged
4 tasks
@github-actions github-actions bot mentioned this pull request Feb 7, 2022
Merged
5 tasks
@aliscco aliscco mentioned this pull request Apr 25, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Apr 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg aeisenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cw-alexcroteau @aeisenberg