Merge main into v1 #946
Merged
Merge main into v1 #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Mergeback v1.1.2 refs/heads/v1 into main
This commit adds a `UserError` class that should be thrown when the cause of an error is fundamentally from user configuration. When sending status reports, avoid sending a `failure` for `UserError`s. This will prevent our diagnostics from pinging us for errors outside of our control.
Add `UserError`
Respect `end-tracing` script instead of deleting one variable
|
@edoardopirovano, since it's late for you, I'll take this one on. |
|
Adding a changelog entry for #938 |
edoardopirovano
approved these changes
Feb 23, 2022
For some reason, the runner was still on 1.0.x.
aeisenberg
force-pushed
the
update-v1.1.3-d7ad71d8
branch
from
8eb3e97
to
42c72a1
Compare
|
We now have a bunch of code scanning errors for a new query. I won't fix them for this PR. I will fix them after the release goes out since the errors are not in new code and are low priority in our situation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging d7ad71d into v1
Conductor for this PR is @edoardopirovano
Contains the following pull requests:
end-tracingscript instead of deleting one variable #938 - Respectend-tracingscript instead of deleting one variable (@edoardopirovano)UserError#942 - AddUserError(@edoardopirovano)Please review the following: