Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift: CommonCrypto test cases for the BrokenCryptoAlgorithm query #13870

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Aug 2, 2023

Adds test cases of the CommonCrypto encryption library, ready for the BrokenCryptoAlgorithm query (currently in draft PR #13649).

@d10c if you cherry-pick this onto your PR, then rename BrokenCryptoAlgorithm.qlref.disabled to just BrokenCryptoAlgorithm.qlref, you should be able to use this. Let me know if anything doesn't look right.

@geoffw0 geoffw0 added no-change-note-required This PR does not need a change note Swift labels Aug 2, 2023
@geoffw0 geoffw0 requested a review from a team as a code owner August 2, 2023 17:38
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I agree with you on the fact that we might as well have these tests in the repo even though there's no query for it (yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-change-note-required This PR does not need a change note Swift
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants