CPP: Add parent class for delete and delete[] #14058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexet
force-pushed
the
delete-or-delete-array
branch
from
b98c6f0
to
384029f
Compare
alexet
force-pushed
the
delete-or-delete-array
branch
from
384029f
to
d699201
Compare
MathiasVP
reviewed
Aug 25, 2023
There was a problem hiding this comment.
The changes LGTM (modulo a few QLDoc suggestions). We should probably add a "deprecated" change note to this PR.
I guess we should also do a DCA run to make sure we didn't mess up some join ordering by adding the new parent class?
Co-authored-by: Mathias Vorreiter Pedersen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a parent to
deleteanddelete[]so that they can be handled together. This also renamesgetAllocatorCallintogetDeallocatorCalland fixes some incorrect documentation.I split this out of the IR work.