Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust: Accept data flow inconsistencies #17944

Closed
wants to merge 1 commit into from
Closed

Rust: Accept data flow inconsistencies #17944

wants to merge 1 commit into from

Conversation

paldepind
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Nov 8, 2024
@paldepind paldepind mentioned this pull request Nov 8, 2024
Merged
geoffw0
geoffw0 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming CI passes.

@geoffw0
Copy link
Contributor

geoffw0 commented Nov 8, 2024

Ah, I think #17943 beat us to it.

@geoffw0
Copy link
Contributor

geoffw0 commented Nov 8, 2024

(my fault, I think I mentioned the underlying problem in two places without linking to each other)

@paldepind
Copy link
Contributor Author

Oh, yeah. They did 😆

@paldepind paldepind closed this Nov 8, 2024
@paldepind paldepind deleted the rust-inconsistency branch November 8, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffw0 geoffw0 geoffw0 approved these changes

Assignees
No one assigned
Labels
Rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paldepind @geoffw0