C#: Update to .NET9. #17999
Merged
C#: Update to .NET9. #17999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
csharp/net9
branch
7 times, most recently
from
2d5341d
to
e6fa73e
Compare
michaelnebel
force-pushed
the
csharp/net9
branch
from
e6fa73e
to
263a4a9
Compare
michaelnebel
added
the
no-change-note-required
hvitved
approved these changes
Nov 19, 2024
| def check_build_out(msg, s): | ||
| lines = s.splitlines() | ||
| lines = s.splitlines() |
There was a problem hiding this comment.
Oh yes. I will do that in a follow up as this PR can merged now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we update the extractor to target .NET 9, which also requires that all our workflows and dependencies are updated accordingly.
This PR is paired with an internal PR. There will be a follow up PR that updates the dependencies further (including Roslyn) and also addresses some of the compiler warnings.
A couple of notes on this PR
TestRunner.csis required because thexunitdependency is updated.dotnet_runanddotnet_buildintegration tests is needed because with .NET 9 the console logger is replaced with terminal logger and the latter makes some formatting of the printed text. This is also listed as a breaking change here.DCA run: https://github.com/github/codeql-dca-main/issues/24870
There are no performance regressions. The alert discrepancies on the powershell buildless project is most likely a side effect of the increased target call precision for this run (this could be mostly wobliness).