Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to user profile #62

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Conversation

jellllly420
Copy link
Contributor

@jellllly420 jellllly420 commented Jan 4, 2024

Pull Request

Closes #13.

Proposed Changes

Add link to user profile.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, or breaking

@jellllly420
Copy link
Contributor Author

Looks like @mentions in Github do not render in files like README.md. (github/markup#209)

This PR keeps raw @mentions in examples in README.md though.

@zkoppert zkoppert added the enhancement New feature or request label Jan 9, 2024
Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for taking the time to get this change in!

contributors.py Outdated Show resolved Hide resolved
contributors.py Outdated Show resolved Hide resolved
env.py Outdated Show resolved Hide resolved
env.py Outdated Show resolved Hide resolved
markdown.py Outdated Show resolved Hide resolved
markdown.py Outdated Show resolved Hide resolved
markdown.py Outdated Show resolved Hide resolved
markdown.py Outdated Show resolved Hide resolved
test_env.py Outdated Show resolved Hide resolved
test_env.py Outdated Show resolved Hide resolved
jellllly420 and others added 2 commits January 10, 2024 18:49
@zkoppert zkoppert merged commit 5190a27 into github:main Jan 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Add link to user profile
4 participants