Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: authenticate with github app installation and repo standardization #80

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented Mar 29, 2024

Closes #71

Pull Request

Proposed Changes

  • allow authentication with github app installation id
  • repo standardization
    • linting configuration
    • Makefile
    • alphabetize :allthethings:
  • update/expand tests
  • update superlinter to v6

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, or breaking

@jmeridth jmeridth requested a review from zkoppert as a code owner March 29, 2024 15:40
@jmeridth
Copy link
Member Author

/me waits for a linting error 😄

@jmeridth jmeridth force-pushed the jm-github-app-authentication branch from 1a10b1f to 40b8ac0 Compare March 29, 2024 15:42
@jmeridth jmeridth force-pushed the jm-github-app-authentication branch 2 times, most recently from adb0797 to e694a2c Compare March 29, 2024 15:54
Closes github#71

- [x] allow authentication with github app installation id
- [x] repo standardization
  - [x] linting configuration
  - [x] Makefile
  - [x] alphabetize :allthethings:
- [x] update/expand tests
- [x] update superlinter to v6

Signed-off-by: jmeridth <[email protected]>
@jmeridth jmeridth force-pushed the jm-github-app-authentication branch from e694a2c to 646608d Compare March 29, 2024 15:55
@jmeridth jmeridth self-assigned this Mar 29, 2024
@jmeridth jmeridth added documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file labels Mar 29, 2024
Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @jmeridth!

@zkoppert zkoppert merged commit 832b651 into github:main Mar 29, 2024
4 checks passed
@jmeridth jmeridth deleted the jm-github-app-authentication branch March 29, 2024 22:05
@zkoppert
Copy link
Member

Deploy a new release on a Friday? 🤔 .... Sure, YOLO!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants