-
Notifications
You must be signed in to change notification settings - Fork 59.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly state that at least one job is required to run and that without, a workflow will fail #34338
Conversation
Explicitly state that at least one job is required to run and that without, a workflow will fail
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@MizouziE Thanks so much for opening a PR! I'll get this triaged for review ✨ |
Hi @MizouziE, and thanks for your PR— I'm afraid we won't be accepting this submission on this occasion:
Thank you for your interest in the GitHub docs! |
Thanks for the reply and explanation @subatoi I appreciate your points. Just wanted to mention that it's possible that people land directly on the pages which are beyond the points addressed in the Anyway, lesson learned and hopefully I'll form a better habit of gathering context beyond the scope of what it is I'm attempting to do. |
Thanks for your engagement @MizouziE—I've reached out to the internal team in question with your feedback, and they may choose to take it further and make some amendments. Please don't be discouraged from raising further contributions—just as a gentle point, it may help to raise an issue first next time, so we can have this kind of discussion there first. |
Why:
Closes: #34337
What's being changed:
The opening paragraph of the overview to:
A workflow run is made up of at least one or more
jobs
, which run in parallel by default. Without any jobs to run, a workflow will fail. To run jobs sequentially, you can define dependencies on other jobs using thejobs.<job_id>.needs
keyword.Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.