Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expires_at is stored as a database datetime column #62

Open
wowyzga opened this issue Nov 10, 2022 · 0 comments
Open

expires_at is stored as a database datetime column #62

wowyzga opened this issue Nov 10, 2022 · 0 comments

Comments

@wowyzga
Copy link

wowyzga commented Nov 10, 2022

Context

During the DST to standard time change, when the SQL server is running in a local time zone, records cannot be found when expires_at is set to 1 hour.

Given a PST time and a fallback to standard time at 2 AM, 1 hour from 1 AM, is going to be still 1 AM. The date s converted to the same date that was entered and few seconds after the record cannot be found again.

The expires_at column should be timezone agnostic, possible solution would be to store it as an integer (epoch time),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant