From 27fea39cec4f4bbe0d74c17f44a12815f29ff746 Mon Sep 17 00:00:00 2001 From: jmeridth Date: Tue, 19 Nov 2024 12:08:58 -0600 Subject: [PATCH] fix: linting errors after super-linter upgrade - [x] group commands instead of instead of individual redirects - [x] double quote variable to prevent globbing and word splitting - [x] disable too-many-positional-arguments pylint linting Signed-off-by: jmeridth --- .github/linters/.python-lint | 1 + .github/workflows/major-version-updater.yml | 4 +--- .github/workflows/release.yml | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/linters/.python-lint b/.github/linters/.python-lint index da0f17d..758f92c 100644 --- a/.github/linters/.python-lint +++ b/.github/linters/.python-lint @@ -435,6 +435,7 @@ disable=bad-inline-option, too-many-function-args, too-many-branches, too-many-locals, + too-many-positional-arguments, too-many-statements, useless-suppression, use-symbolic-message-instead, diff --git a/.github/workflows/major-version-updater.yml b/.github/workflows/major-version-updater.yml index e03b876..db09649 100644 --- a/.github/workflows/major-version-updater.yml +++ b/.github/workflows/major-version-updater.yml @@ -23,9 +23,7 @@ jobs: tag=${GITHUB_REF/refs\/tags\//} version=${tag#v} major=${version%%.*} - echo "tag=${tag}" >> "$GITHUB_OUTPUT" - echo "version=${version}" >> "$GITHUB_OUTPUT" - echo "major=${major}" >> "$GITHUB_OUTPUT" + { echo "tag=${tag}"; echo "version=${version}"; echo "major=${major}"; } >> "$GITHUB_OUTPUT" - name: force update major tag run: | diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 5e3fe22..a959456 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -42,7 +42,7 @@ jobs: id: get_tag_name run: | short_tag=$(echo ${{ steps.release-drafter.outputs.tag_name }} | cut -d. -f1) - echo "SHORT_TAG=$short_tag" >> $GITHUB_OUTPUT + echo "SHORT_TAG=$short_tag" >> "$GITHUB_OUTPUT" create_action_images: needs: create_release runs-on: ubuntu-latest