From 7b454f72e8f6db8d5608e1c6063e4573364b3e4c Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 18 Nov 2024 18:14:29 +0000 Subject: [PATCH 1/2] chore(deps): bump the dependencies group with 2 updates Bumps the dependencies group with 2 updates: [super-linter/super-linter](https://github.com/super-linter/super-linter) and [github/codeql-action](https://github.com/github/codeql-action). Updates `super-linter/super-linter` from 7.1.0 to 7.2.0 - [Release notes](https://github.com/super-linter/super-linter/releases) - [Changelog](https://github.com/super-linter/super-linter/blob/main/CHANGELOG.md) - [Commits](https://github.com/super-linter/super-linter/compare/b92721f792f381cedc002ecdbb9847a15ece5bb8...e1cb86b6e8d119f789513668b4b30bf17fe1efe4) Updates `github/codeql-action` from 3.27.1 to 3.27.4 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](https://github.com/github/codeql-action/compare/4f3212b61783c3c68e8309a0f18a699764811cda...ea9e4e37992a54ee68a9622e985e60c8e8f12d9f) --- updated-dependencies: - dependency-name: super-linter/super-linter dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies ... Signed-off-by: dependabot[bot] --- .github/workflows/linter.yaml | 2 +- .github/workflows/scorecard.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/linter.yaml b/.github/workflows/linter.yaml index fd1fb21..f3ecf3a 100644 --- a/.github/workflows/linter.yaml +++ b/.github/workflows/linter.yaml @@ -30,7 +30,7 @@ jobs: run: | pip install -r requirements.txt -r requirements-test.txt - name: Lint Code Base - uses: super-linter/super-linter@b92721f792f381cedc002ecdbb9847a15ece5bb8 # v7.1.0 + uses: super-linter/super-linter@e1cb86b6e8d119f789513668b4b30bf17fe1efe4 # v7.2.0 env: DEFAULT_BRANCH: main GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/scorecard.yml b/.github/workflows/scorecard.yml index c4e94bb..a767cbc 100644 --- a/.github/workflows/scorecard.yml +++ b/.github/workflows/scorecard.yml @@ -42,6 +42,6 @@ jobs: path: results.sarif retention-days: 5 - name: "Upload to code-scanning" - uses: github/codeql-action/upload-sarif@4f3212b61783c3c68e8309a0f18a699764811cda # v3.24.9 + uses: github/codeql-action/upload-sarif@ea9e4e37992a54ee68a9622e985e60c8e8f12d9f # v3.24.9 with: sarif_file: results.sarif From 27fea39cec4f4bbe0d74c17f44a12815f29ff746 Mon Sep 17 00:00:00 2001 From: jmeridth Date: Tue, 19 Nov 2024 12:08:58 -0600 Subject: [PATCH 2/2] fix: linting errors after super-linter upgrade - [x] group commands instead of instead of individual redirects - [x] double quote variable to prevent globbing and word splitting - [x] disable too-many-positional-arguments pylint linting Signed-off-by: jmeridth --- .github/linters/.python-lint | 1 + .github/workflows/major-version-updater.yml | 4 +--- .github/workflows/release.yml | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/linters/.python-lint b/.github/linters/.python-lint index da0f17d..758f92c 100644 --- a/.github/linters/.python-lint +++ b/.github/linters/.python-lint @@ -435,6 +435,7 @@ disable=bad-inline-option, too-many-function-args, too-many-branches, too-many-locals, + too-many-positional-arguments, too-many-statements, useless-suppression, use-symbolic-message-instead, diff --git a/.github/workflows/major-version-updater.yml b/.github/workflows/major-version-updater.yml index e03b876..db09649 100644 --- a/.github/workflows/major-version-updater.yml +++ b/.github/workflows/major-version-updater.yml @@ -23,9 +23,7 @@ jobs: tag=${GITHUB_REF/refs\/tags\//} version=${tag#v} major=${version%%.*} - echo "tag=${tag}" >> "$GITHUB_OUTPUT" - echo "version=${version}" >> "$GITHUB_OUTPUT" - echo "major=${major}" >> "$GITHUB_OUTPUT" + { echo "tag=${tag}"; echo "version=${version}"; echo "major=${major}"; } >> "$GITHUB_OUTPUT" - name: force update major tag run: | diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 5e3fe22..a959456 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -42,7 +42,7 @@ jobs: id: get_tag_name run: | short_tag=$(echo ${{ steps.release-drafter.outputs.tag_name }} | cut -d. -f1) - echo "SHORT_TAG=$short_tag" >> $GITHUB_OUTPUT + echo "SHORT_TAG=$short_tag" >> "$GITHUB_OUTPUT" create_action_images: needs: create_release runs-on: ubuntu-latest