Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended make lint Execution Time #112

Closed
Okabe-Junya opened this issue Sep 10, 2023 · 0 comments · Fixed by #113
Closed

Extended make lint Execution Time #112

Okabe-Junya opened this issue Sep 10, 2023 · 0 comments · Fixed by #113

Comments

@Okabe-Junya
Copy link
Contributor

Okabe-Junya commented Sep 10, 2023

What's the issue?

When I code for this project and run make lint before committing, it takes a long time.

Why is this happening?

I've set up the development environment for this repo using venv. Therefore, there's a venv directory (which isn't being tracked by git, by the way). Tools like flake8 and pylint check this directory, resulting in the extended execution time.

How should we resolve this?

Modifying the Makefile or .pylintrc could likely address this issue.

Future considerations (not addressed here)

While we currently pass options as arguments when executing flake8, we might also consider using a configuration file like pyproject.toml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant