Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Measure time to merge for pull requests #37

Closed
zkoppert opened this issue Jun 29, 2023 · 3 comments · Fixed by #111
Closed

Feature: Measure time to merge for pull requests #37

zkoppert opened this issue Jun 29, 2023 · 3 comments · Fixed by #111
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@zkoppert
Copy link
Member

No description provided.

@zkoppert zkoppert added the enhancement New feature or request label Jun 29, 2023
@vibin
Copy link

vibin commented Jul 30, 2023

Would this consider the time at which the first reviewer was assigned as the start time?

@zkoppert
Copy link
Member Author

Great question! I had originally thought that it would be the time difference between when a pull request was opened to when it was merged. I think that may be the more comprehensive way to measure this since not all pull requests have a review before being merged.

@edmorley
Copy link

time difference between when a pull request was opened to when it was merged

I think time spent in draft status would need to be excluded too?

@zkoppert zkoppert added the good first issue Good for newcomers label Aug 25, 2023
@PressXtoChris PressXtoChris mentioned this issue Sep 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature: Ignore PR time spent as draft, measure PRs by merge time PressXtoChris/issue-metrics
3 participants
@edmorley @vibin @zkoppert