Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: authenticate with github app installation and repo standardization #221

Merged
merged 12 commits into from
Mar 26, 2024

Commits on Mar 22, 2024

  1. feat: authenticate with github app instllation

    - [x] add ability to authenticate with GitHub App Installation
    - [x] add tests for GitHub App Installation
    - [x] add more tests for env vars
    
    repo updates to match standards:
    
    - [x] alphabetize :allthethings:
    - [x] add requirements-test.txt to version our testing dependencies
    - [x] update Makefile to point linting commands to our linter configs
          that the GitHub Action workflows use
    - [x] add linter configs
    - [x] add checkov exemptions to Dockerfile
      - custom user - can't do, need root for GitHub action workspace access
    - [x] update README, splitting authentication section
    - [x] change .pylintrc to .python-lint (pylint default config file)
    - [x] updated all examples to default to read contents permissions
    - [x] linted files
    
    I'd highly suggest this be a major version change as there are breaking changes:
    
    - [x] standardize boolean environment variables (true or false)
    - [x] drop GITHUB_SERVER_URL and instead use GITHUB_ENTERPRISE_URL for enterprise
          customers (matches our other repos)
    
    Signed-off-by: jmeridth <[email protected]>
    jmeridth committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    4fdfe82 View commit details
    Browse the repository at this point in the history
  2. Update README.md

    Co-authored-by: Zack Koppert <[email protected]>
    jmeridth and zkoppert authored Mar 22, 2024
    Configuration menu
    Copy the full SHA
    92ced17 View commit details
    Browse the repository at this point in the history
  3. fix: linting fixes

    more to come
    
    Signed-off-by: jmeridth <[email protected]>
    jmeridth committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    59a2534 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2024

  1. chore: more linting (mypy) fixes. more to come

    Signed-off-by: jmeridth <[email protected]>
    jmeridth committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    3a603c7 View commit details
    Browse the repository at this point in the history
  2. chore: fix incompatable default argument

    Signed-off-by: jmeridth <[email protected]>
    jmeridth committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    f0613ee View commit details
    Browse the repository at this point in the history
  3. fix: linting, consistent return types, we got this

    Signed-off-by: jmeridth <[email protected]>
    jmeridth committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    be1272d View commit details
    Browse the repository at this point in the history
  4. fix: more linting, 3 to go

    replace comments with variables, causes ensured maintenance of meaning
    
    Signed-off-by: jmeridth <[email protected]>
    jmeridth committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    eed2aaa View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Configuration menu
    Copy the full SHA
    bef0ad3 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. fix: linting, still 3 mypy errors, very close

    Signed-off-by: jmeridth <[email protected]>
    jmeridth committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    ccfae8b View commit details
    Browse the repository at this point in the history
  2. fix: linting, 2 down 1 to go

    Signed-off-by: jmeridth <[email protected]>
    jmeridth committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    6276ac0 View commit details
    Browse the repository at this point in the history
  3. fix: markdown linting

    Signed-off-by: jmeridth <[email protected]>
    jmeridth committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    8c81f51 View commit details
    Browse the repository at this point in the history
  4. fix: linting by ignoring

    - will reassess later
    
    Signed-off-by: jmeridth <[email protected]>
    jmeridth committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    ad44a93 View commit details
    Browse the repository at this point in the history