From 417fc0146090f286e9462e1699f2166d60520349 Mon Sep 17 00:00:00 2001
From: Issy Long <issyl0@github.com>
Date: Mon, 10 Oct 2022 13:54:17 +0000
Subject: [PATCH 1/3] Delete GitHub/Accessibility cops; point to
 `rubocop-rails-accessibility`

- Accessibility rules used to live in this gem, but
  https://github.com/github/rubocop-rails-accessibility now exists with
  the rules that were here and more. The monolith uses the new gem.
- For projects that haven't moved over yet, signpost in the README (and
  the eventual new gem version release notes, please) that accessibility
  cops have moved.
- Fixes https://github.com/github/code-scanning/issues/7337.
---
 README.md                                     |  3 +-
 config/accessibility.yml                      | 15 --------
 .../cop/github/accessibility/image_has_alt.rb | 26 -------------
 .../cop/github/accessibility/link_has_href.rb | 25 ------------
 .../accessibility/no_positive_tabindex.rb     | 32 ----------------
 .../accessibility/no_redundant_image_alt.rb   | 38 -------------------
 test/test_image_has_alt.rb                    | 28 --------------
 test/test_link_has_href.rb                    | 35 -----------------
 test/test_no_positive_tabindex.rb             | 28 --------------
 test/test_no_redundant_image_alt.rb           | 28 --------------
 10 files changed, 2 insertions(+), 256 deletions(-)
 delete mode 100644 config/accessibility.yml
 delete mode 100644 lib/rubocop/cop/github/accessibility/image_has_alt.rb
 delete mode 100644 lib/rubocop/cop/github/accessibility/link_has_href.rb
 delete mode 100644 lib/rubocop/cop/github/accessibility/no_positive_tabindex.rb
 delete mode 100644 lib/rubocop/cop/github/accessibility/no_redundant_image_alt.rb
 delete mode 100644 test/test_image_has_alt.rb
 delete mode 100644 test/test_link_has_href.rb
 delete mode 100644 test/test_no_positive_tabindex.rb
 delete mode 100644 test/test_no_redundant_image_alt.rb

diff --git a/README.md b/README.md
index ab466b1..cdca406 100644
--- a/README.md
+++ b/README.md
@@ -19,9 +19,10 @@ inherit_gem:
   rubocop-github:
     - config/default.yml
     - config/rails.yml
-    - config/accessibility.yml
 ```
 
+💭 Looking for `config/accessibility.yml` and the `GitHub/Accessibility` configs? [They have moved](https://github.com/github/rubocop-rails-accessibility) to a new gem.
+
 ### Legacy usage
 
 If you are using a rubocop version < 1.0.0, you can use rubocop-github version
diff --git a/config/accessibility.yml b/config/accessibility.yml
deleted file mode 100644
index 1908cad..0000000
--- a/config/accessibility.yml
+++ /dev/null
@@ -1,15 +0,0 @@
-require:
-  - rubocop/cop/github/accessibility
-
-GitHub/Accessibility/ImageHasAlt:
-  Enabled: true
-  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/image-has-alt.md
-GitHub/Accessibility/LinkHasHref:
-  Enabled: true
-  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/link-has-href.md
-GitHub/Accessibility/NoPositiveTabindex:
-  Enabled: true
-  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/no-positive-tabindex.md
-GitHub/Accessibility/NoRedundantImageAlt:
-  Enabled: true
-  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/no-redundant-image-alt.md
diff --git a/lib/rubocop/cop/github/accessibility/image_has_alt.rb b/lib/rubocop/cop/github/accessibility/image_has_alt.rb
deleted file mode 100644
index 698d922..0000000
--- a/lib/rubocop/cop/github/accessibility/image_has_alt.rb
+++ /dev/null
@@ -1,26 +0,0 @@
-# frozen_string_literal: true
-
-require "rubocop"
-
-module RuboCop
-  module Cop
-    module GitHub
-      module Accessibility
-        class ImageHasAlt < Base
-          MSG = "Images should have an alt prop with meaningful text or an empty string for decorative images"
-
-          def_node_search :has_alt_attribute?, "(sym :alt)"
-
-          def on_send(node)
-            receiver, method_name, _= *node
-
-            if receiver.nil? && method_name == :image_tag
-              alt = has_alt_attribute?(node)
-              add_offense(node.loc.selector) if alt.nil?
-            end
-          end
-        end
-      end
-    end
-  end
-end
diff --git a/lib/rubocop/cop/github/accessibility/link_has_href.rb b/lib/rubocop/cop/github/accessibility/link_has_href.rb
deleted file mode 100644
index 751c564..0000000
--- a/lib/rubocop/cop/github/accessibility/link_has_href.rb
+++ /dev/null
@@ -1,25 +0,0 @@
-# frozen_string_literal: true
-
-require "rubocop"
-
-module RuboCop
-  module Cop
-    module GitHub
-      module Accessibility
-        class LinkHasHref < Base
-          MSG = "Links should go somewhere, you probably want to use a `<button>` instead.".freeze
-
-          def on_send(node)
-            receiver, method_name, *args = *node
-
-            if receiver.nil? && method_name == :link_to
-              if args.length == 1 || (args.length > 1 && args[1].type == :str && args[1].children.first == "#")
-                add_offense(node.loc.selector)
-              end
-            end
-          end
-        end
-      end
-    end
-  end
-end
diff --git a/lib/rubocop/cop/github/accessibility/no_positive_tabindex.rb b/lib/rubocop/cop/github/accessibility/no_positive_tabindex.rb
deleted file mode 100644
index 2a63fbe..0000000
--- a/lib/rubocop/cop/github/accessibility/no_positive_tabindex.rb
+++ /dev/null
@@ -1,32 +0,0 @@
-# frozen_string_literal: true
-
-require "rubocop"
-
-module RuboCop
-  module Cop
-    module GitHub
-      module Accessibility
-        class NoPositiveTabindex < Base
-          MSG = "Positive tabindex is error-prone and often inaccessible."
-
-          def on_send(node)
-            receiver, method_name, *args = *node
-            if receiver.nil?
-              args.select do |arg|
-                arg.type == :hash
-              end.each do |hash|
-                hash.each_pair do |key, value|
-                  next if key.type == :dsym
-                  next unless key.respond_to?(:value)
-                  if key.value == :tabindex && value.source.to_i > 0
-                    add_offense(hash)
-                  end
-                end
-              end
-            end
-          end
-        end
-      end
-    end
-  end
-end
diff --git a/lib/rubocop/cop/github/accessibility/no_redundant_image_alt.rb b/lib/rubocop/cop/github/accessibility/no_redundant_image_alt.rb
deleted file mode 100644
index 0f84a87..0000000
--- a/lib/rubocop/cop/github/accessibility/no_redundant_image_alt.rb
+++ /dev/null
@@ -1,38 +0,0 @@
-# frozen_string_literal: true
-
-require "rubocop"
-
-module RuboCop
-  module Cop
-    module GitHub
-      module Accessibility
-        class NoRedundantImageAlt < Base
-          MSG = "Alt prop should not contain `image` or `picture` as screen readers already announce the element as an image"
-          REDUNDANT_ALT_WORDS = %w(image picture)
-
-          def_node_search :redundant_alt?, "(pair (sym :alt) (str #contains_redundant_alt_text?))"
-
-          def on_send(node)
-            receiver, method_name, _= *node
-
-            if receiver.nil? && method_name == :image_tag
-              if redundant_alt?(node)
-                add_offense(node.loc.selector)
-              end
-            end
-          end
-
-          private
-
-          def contains_redundant_alt_text?(string)
-            return false if string.empty?
-
-            if (string.downcase.split & REDUNDANT_ALT_WORDS).any?
-              return true
-            end
-          end
-        end
-      end
-    end
-  end
-end
diff --git a/test/test_image_has_alt.rb b/test/test_image_has_alt.rb
deleted file mode 100644
index e4fb08a..0000000
--- a/test/test_image_has_alt.rb
+++ /dev/null
@@ -1,28 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "./cop_test"
-require "minitest/autorun"
-require "rubocop/cop/github/accessibility/image_has_alt"
-
-class TestImageHasAlt < CopTest
-  def cop_class
-    RuboCop::Cop::GitHub::Accessibility::ImageHasAlt
-  end
-
-  def test_image_has_alt_offense
-    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
-      <%= image_tag "spinners/octocat-spinner-16px.gif", size: "12x12" %>
-    ERB
-
-    assert_equal 1, offenses.count
-    assert_equal "Images should have an alt prop with meaningful text or an empty string for decorative images", offenses[0].message
-  end
-
-  def test_image_has_alt_no_offense
-    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
-      <%= image_tag "spinners/octocat-spinner-16px.gif", size: "12x12", alt: "GitHub Logo spinner" %>
-    ERB
-
-    assert_equal 0, offenses.count
-  end
-end
diff --git a/test/test_link_has_href.rb b/test/test_link_has_href.rb
deleted file mode 100644
index b68dc92..0000000
--- a/test/test_link_has_href.rb
+++ /dev/null
@@ -1,35 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "./cop_test"
-require "minitest/autorun"
-require "rubocop/cop/github/accessibility/link_has_href"
-
-class LinkHasHref < CopTest
-  def cop_class
-    RuboCop::Cop::GitHub::Accessibility::LinkHasHref
-  end
-
-  def test_link_has_href_offense
-    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
-      <%= link_to 'Go to GitHub' %>
-    ERB
-
-    assert_equal 1, offenses.count
-    assert_equal "Links should go somewhere, you probably want to use a `<button>` instead.", offenses[0].message
-
-    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
-      <%= link_to 'Go to GitHub', '#' %>
-    ERB
-
-    assert_equal 1, offenses.count
-    assert_equal "Links should go somewhere, you probably want to use a `<button>` instead.", offenses[0].message
-  end
-
-  def test_link_has_href_no_offense
-    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
-      <%= link_to 'Go to GitHub', 'https://github.com/' %>
-    ERB
-
-    assert_equal 0, offenses.count
-  end
-end
diff --git a/test/test_no_positive_tabindex.rb b/test/test_no_positive_tabindex.rb
deleted file mode 100644
index 482c9c4..0000000
--- a/test/test_no_positive_tabindex.rb
+++ /dev/null
@@ -1,28 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "./cop_test"
-require "minitest/autorun"
-require "rubocop/cop/github/accessibility/no_positive_tabindex"
-
-class NoPositiveTabindex < CopTest
-  def cop_class
-    RuboCop::Cop::GitHub::Accessibility::NoPositiveTabindex
-  end
-
-  def test_no_positive_tabindex_alt_offense
-    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
-      <%= button_tag "Continue", :tabindex => 3 %>
-    ERB
-
-    assert_equal 1, offenses.count
-    assert_equal "Positive tabindex is error-prone and often inaccessible.", offenses[0].message
-  end
-
-  def test_no_positive_tabindex_alt_no_offense
-    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
-       <%= button_tag "Continue", :tabindex => -1 %>
-    ERB
-
-    assert_equal 0, offenses.count
-  end
-end
diff --git a/test/test_no_redundant_image_alt.rb b/test/test_no_redundant_image_alt.rb
deleted file mode 100644
index c8e9164..0000000
--- a/test/test_no_redundant_image_alt.rb
+++ /dev/null
@@ -1,28 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "./cop_test"
-require "minitest/autorun"
-require "rubocop/cop/github/accessibility/no_redundant_image_alt"
-
-class NoRedundantImageAlt < CopTest
-  def cop_class
-    RuboCop::Cop::GitHub::Accessibility::NoRedundantImageAlt
-  end
-
-  def test_no_redundant_image_alt_offense
-    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
-      <%= image_tag "cat.gif", size: "12x12", alt: "Picture of a cat" %>
-    ERB
-
-    assert_equal 1, offenses.count
-    assert_equal "Alt prop should not contain `image` or `picture` as screen readers already announce the element as an image", offenses[0].message
-  end
-
-  def test_no_redundant_image_alt_no_offense
-    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
-       <%= image_tag "cat.gif", size: "12x12", alt: "A black cat" %>
-    ERB
-
-    assert_equal 0, offenses.count
-  end
-end

From 7a083dae1e7df78047a34269109e33821d9c7492 Mon Sep 17 00:00:00 2001
From: Issy Long <issyl0@github.com>
Date: Mon, 10 Oct 2022 15:11:19 +0100
Subject: [PATCH 2/3] README: Language tweak.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Adrián Bolonio <bolonio@github.com>
---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.md b/README.md
index cdca406..5cad859 100644
--- a/README.md
+++ b/README.md
@@ -21,7 +21,7 @@ inherit_gem:
     - config/rails.yml
 ```
 
-💭 Looking for `config/accessibility.yml` and the `GitHub/Accessibility` configs? [They have moved](https://github.com/github/rubocop-rails-accessibility) to a new gem.
+💭 Looking for `config/accessibility.yml` and the `GitHub/Accessibility` configs? [They have been moved](https://github.com/github/rubocop-rails-accessibility) to a new gem.
 
 ### Legacy usage
 

From e408daea3a5dcf34a9c4d0f6e39c56a1104501b2 Mon Sep 17 00:00:00 2001
From: Issy Long <issyl0@github.com>
Date: Mon, 10 Oct 2022 15:14:59 +0100
Subject: [PATCH 3/3] README: (nit) Move link text over slightly

Co-authored-by: Sam Partington <sampart@github.com>
---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.md b/README.md
index 5cad859..b5fb2ad 100644
--- a/README.md
+++ b/README.md
@@ -21,7 +21,7 @@ inherit_gem:
     - config/rails.yml
 ```
 
-💭 Looking for `config/accessibility.yml` and the `GitHub/Accessibility` configs? [They have been moved](https://github.com/github/rubocop-rails-accessibility) to a new gem.
+💭 Looking for `config/accessibility.yml` and the `GitHub/Accessibility` configs? They have been moved to [a new gem](https://github.com/github/rubocop-rails-accessibility).
 
 ### Legacy usage