From d97b12c16427c2e2e3be173fd51e608a352cd578 Mon Sep 17 00:00:00 2001
From: "Ben Sheldon [he/him]" <bensheldon@github.com>
Date: Thu, 13 Oct 2022 08:44:48 -0700
Subject: [PATCH 01/11] Create CONTRIBUTING.md

---
 CONTRIBUTING.md | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 CONTRIBUTING.md

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
new file mode 100644
index 0000000..d180481
--- /dev/null
+++ b/CONTRIBUTING.md
@@ -0,0 +1,13 @@
+# Contributing
+
+## Releasing a new version
+
+1. Update `rubocop-github.gemspec` with the next version number
+2. Update the `CHANGELOG` with changes and contributor
+3. Run `bundle` to update gem version contained in the lockfile
+4. Make a commit: `Release v{VERSION}`
+5. Tag the commit : `git tag v{VERSION}`
+6. Create the package: `gem build rubocop-github.gemspec`
+7.  Push to GitHub: `git push origin && git push origin --tags`
+8. Push to Rubygems: `gem push rubocop-github-{VERSION}.gem`
+9. Publish a new release on GitHub: https://github.com/github/rubocop-github/releases/new

From ce23317087c8e93ed628deebab828722eb9f9446 Mon Sep 17 00:00:00 2001
From: Ben Sheldon <bensheldon@gmail.com>
Date: Thu, 13 Oct 2022 13:41:13 -0700
Subject: [PATCH 02/11] Replace custom `RailsApplicationRecord` and
 `RailsRenderInline` cops with their upstream equivalent

---
 config/rails.yml                              | 10 +--
 config/rails_cops.yml                         | 12 ----
 guides/rails-render-inline.md                 | 27 --------
 .../cop/github/rails_application_record.rb    | 29 ---------
 lib/rubocop/cop/github/rails_render_inline.rb | 29 ---------
 test/test_rails_application_record.rb         | 39 ------------
 test/test_rails_render_inline.rb              | 62 -------------------
 7 files changed, 2 insertions(+), 206 deletions(-)
 delete mode 100644 guides/rails-render-inline.md
 delete mode 100644 lib/rubocop/cop/github/rails_application_record.rb
 delete mode 100644 lib/rubocop/cop/github/rails_render_inline.rb
 delete mode 100644 test/test_rails_application_record.rb
 delete mode 100644 test/test_rails_render_inline.rb

diff --git a/config/rails.yml b/config/rails.yml
index e414a00..afe402c 100644
--- a/config/rails.yml
+++ b/config/rails.yml
@@ -2,9 +2,6 @@ require:
   - rubocop-github-rails
   - rubocop-rails
 
-GitHub/RailsApplicationRecord:
-  Enabled: true
-
 GitHub/RailsControllerRenderActionSymbol:
   Enabled: true
 
@@ -17,9 +14,6 @@ GitHub/RailsControllerRenderPathsExist:
 GitHub/RailsControllerRenderShorthand:
   Enabled: true
 
-GitHub/RailsRenderInline:
-  Enabled: true
-
 GitHub/RailsRenderObjectCollection:
   Enabled: false
 
@@ -94,7 +88,7 @@ Rails/ApplicationMailer:
   Enabled: false
 
 Rails/ApplicationRecord:
-  Enabled: false
+  Enabled: true
 
 Rails/ArelStar:
   Enabled: false
@@ -307,7 +301,7 @@ Rails/RelativeDateConstant:
   Enabled: false
 
 Rails/RenderInline:
-  Enabled: false
+  Enabled: true
 
 Rails/RenderPlainText:
   Enabled: false
diff --git a/config/rails_cops.yml b/config/rails_cops.yml
index ef3d9a4..87363fb 100644
--- a/config/rails_cops.yml
+++ b/config/rails_cops.yml
@@ -1,6 +1,3 @@
-GitHub/RailsApplicationRecord:
-  Enabled: pending
-
 GitHub/RailsControllerRenderActionSymbol:
   Enabled: pending
   Include:
@@ -25,15 +22,6 @@ GitHub/RailsControllerRenderShorthand:
   Include:
     - 'app/controllers/**/*.rb'
 
-GitHub/RailsRenderInline:
-  Enabled: pending
-  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/rails-controller-render-inline.md
-  Include:
-    - 'app/controllers/**/*.rb'
-    - 'app/helpers/**/*.rb'
-    - 'app/view_models/**/*.rb'
-    - 'app/views/**/*.erb'
-
 GitHub/RailsRenderObjectCollection:
   Enabled: pending
 
diff --git a/guides/rails-render-inline.md b/guides/rails-render-inline.md
deleted file mode 100644
index 8b5fa9b..0000000
--- a/guides/rails-render-inline.md
+++ /dev/null
@@ -1,27 +0,0 @@
-# GitHub/RailsRenderInline
-
-tldr; Do not use `render inline:`.
-
-## Rendering plain text
-
-``` ruby
-render inline: "Just plain text" # bad
-```
-
-The `inline:` option is often misused when plain text is being returned. Instead use `render plain: "Just plain text"`.
-
-## Rendering a dynamic ERB string
-
-String `#{}` interpolation is often misused with `render inline:` instead of using `<%= %>` interpolation. This will lead to a memory leak where an ERB method will be compiled and cached for each invocation of `render inline:`.
-
-``` ruby
-render inline: "Hello #{@name}" # bad
-```
-
-## Rendering static ERB strings
-
-``` ruby
-render inline: "Hello <%= @name %>" # bad
-```
-
-If you are passing a static ERB string to `render inline:`, this string is best moved to a `.erb` template under `app/views`. Template files are able to be precompiled at boot time.
diff --git a/lib/rubocop/cop/github/rails_application_record.rb b/lib/rubocop/cop/github/rails_application_record.rb
deleted file mode 100644
index 1ec30cf..0000000
--- a/lib/rubocop/cop/github/rails_application_record.rb
+++ /dev/null
@@ -1,29 +0,0 @@
-# frozen_string_literal: true
-
-require "rubocop"
-
-module RuboCop
-  module Cop
-    module GitHub
-      class RailsApplicationRecord < Base
-        MSG = "Models should subclass from ApplicationRecord"
-
-        def_node_matcher :active_record_base_const?, <<-PATTERN
-          (const (const nil? :ActiveRecord) :Base)
-        PATTERN
-
-        def_node_matcher :application_record_const?, <<-PATTERN
-          (const nil? :ApplicationRecord)
-        PATTERN
-
-        def on_class(node)
-          klass, superclass, _ = *node
-
-          if active_record_base_const?(superclass) && !(application_record_const?(klass))
-            add_offense(superclass)
-          end
-        end
-      end
-    end
-  end
-end
diff --git a/lib/rubocop/cop/github/rails_render_inline.rb b/lib/rubocop/cop/github/rails_render_inline.rb
deleted file mode 100644
index 8f76fb2..0000000
--- a/lib/rubocop/cop/github/rails_render_inline.rb
+++ /dev/null
@@ -1,29 +0,0 @@
-# frozen_string_literal: true
-
-require "rubocop"
-
-module RuboCop
-  module Cop
-    module GitHub
-      class RailsRenderInline < Base
-        MSG = "Avoid `render inline:`"
-
-        def_node_matcher :render_with_options?, <<-PATTERN
-          (send nil? {:render :render_to_string} (hash $...))
-        PATTERN
-
-        def_node_matcher :inline_key?, <<-PATTERN
-          (pair (sym :inline) $_)
-        PATTERN
-
-        def on_send(node)
-          if option_pairs = render_with_options?(node)
-            if option_pairs.detect { |pair| inline_key?(pair) }
-              add_offense(node)
-            end
-          end
-        end
-      end
-    end
-  end
-end
diff --git a/test/test_rails_application_record.rb b/test/test_rails_application_record.rb
deleted file mode 100644
index 7ac7794..0000000
--- a/test/test_rails_application_record.rb
+++ /dev/null
@@ -1,39 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "./cop_test"
-require "minitest/autorun"
-require "rubocop/cop/github/rails_application_record"
-
-class TestRailsApplicationRecord < CopTest
-  def cop_class
-    RuboCop::Cop::GitHub::RailsApplicationRecord
-  end
-
-  def test_good_model
-    offenses = investigate(cop, <<-RUBY)
-      class Repository < ApplicationRecord
-      end
-    RUBY
-
-    assert_empty offenses.map(&:message)
-  end
-
-  def test_application_record_model
-    offenses = investigate(cop, <<-RUBY)
-      class ApplicationRecord < ActiveRecord::Base
-      end
-    RUBY
-
-    assert_empty offenses.map(&:message)
-  end
-
-  def test_bad_model
-    offenses = investigate(cop, <<-RUBY)
-      class Repository < ActiveRecord::Base
-      end
-    RUBY
-
-    assert_equal 1, offenses.count
-    assert_equal "Models should subclass from ApplicationRecord", offenses.first.message
-  end
-end
diff --git a/test/test_rails_render_inline.rb b/test/test_rails_render_inline.rb
deleted file mode 100644
index 53d5cad..0000000
--- a/test/test_rails_render_inline.rb
+++ /dev/null
@@ -1,62 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "./cop_test"
-require "minitest/autorun"
-require "rubocop/cop/github/rails_render_inline"
-
-class TestRailsRenderInline < CopTest
-  def cop_class
-    RuboCop::Cop::GitHub::RailsRenderInline
-  end
-
-  def test_render_string_no_offense
-    offenses = investigate cop, <<-RUBY, "app/controllers/foo_controller.rb"
-      class FooController < ActionController::Base
-        def index
-          render template: "index"
-        end
-
-        def show
-          render template: "show.html.erb", locals: { foo: @foo }
-        end
-      end
-    RUBY
-
-    assert_equal 0, offenses.count
-  end
-
-  def test_render_inline_offense
-    offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
-      class ProductsController < ActionController::Base
-        def index
-          render inline: "<% products.each do |p| %><p><%= p.name %></p><% end %>"
-        end
-      end
-    RUBY
-
-    assert_equal 1, offenses.count
-    assert_equal "Avoid `render inline:`", offenses[0].message
-  end
-
-  def test_render_status_with_inline_offense
-    offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
-      class ProductsController < ActionController::Base
-        def index
-          render status: 200, inline: "<% products.each do |p| %><p><%= p.name %></p><% end %>"
-        end
-      end
-    RUBY
-
-    assert_equal 1, offenses.count
-    assert_equal "Avoid `render inline:`", offenses[0].message
-  end
-
-  def test_erb_render_inline_offense
-    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
-      <%= render inline: template %>
-    ERB
-
-    assert_equal 1, offenses.count
-    assert_equal "Avoid `render inline:`", offenses[0].message
-  end
-end

From 15a6e783a40980e48da73468c95ab240b7ca48d5 Mon Sep 17 00:00:00 2001
From: Ben Sheldon <bensheldon@gmail.com>
Date: Thu, 13 Oct 2022 14:03:21 -0700
Subject: [PATCH 03/11] Add Contribution instructions, code of conduct, and
 codeowners

---
 CODEOWNERS         |  1 +
 CODE_OF_CONDUCT.md | 73 ++++++++++++++++++++++++++++++++++++++++++++++
 CONTRIBUTING.md    | 47 +++++++++++++++++++++++------
 README.md          |  2 +-
 4 files changed, 113 insertions(+), 10 deletions(-)
 create mode 100644 CODEOWNERS
 create mode 100644 CODE_OF_CONDUCT.md

diff --git a/CODEOWNERS b/CODEOWNERS
new file mode 100644
index 0000000..6e12c3b
--- /dev/null
+++ b/CODEOWNERS
@@ -0,0 +1 @@
+* @github/ruby-archiecture-reviewers
diff --git a/CODE_OF_CONDUCT.md b/CODE_OF_CONDUCT.md
new file mode 100644
index 0000000..2ef4f60
--- /dev/null
+++ b/CODE_OF_CONDUCT.md
@@ -0,0 +1,73 @@
+# Contributor Covenant Code of Conduct
+
+## Our Pledge
+
+In the interest of fostering an open and welcoming environment, we as
+contributors and maintainers pledge to make participation in our project and
+our community a harassment-free experience for everyone, regardless of age, body
+size, disability, ethnicity, sex characteristics, gender identity and expression,
+level of experience, education, socio-economic status, nationality, personal
+appearance, race, religion, or sexual identity and orientation.
+
+## Our Standards
+
+Examples of behavior that contributes to creating a positive environment
+include:
+
+* Using welcoming and inclusive language
+* Being respectful of differing viewpoints and experiences
+* Gracefully accepting constructive criticism
+* Focusing on what is best for the community
+* Showing empathy towards other community members
+
+Examples of unacceptable behavior by participants include:
+
+* The use of sexualized language or imagery and unwelcome sexual attention or
+  advances
+* Trolling, insulting/derogatory comments, and personal or political attacks
+* Public or private harassment
+* Publishing others' private information, such as a physical or electronic
+  address, without explicit permission
+* Other conduct which could reasonably be considered inappropriate in a
+  professional setting
+
+## Our Responsibilities
+
+Project maintainers are responsible for clarifying the standards of acceptable
+behavior and are expected to take appropriate and fair corrective action in
+response to any instances of unacceptable behavior.
+
+Project maintainers have the right and responsibility to remove, edit, or
+reject comments, commits, code, wiki edits, issues, and other contributions
+that are not aligned to this Code of Conduct, or to ban temporarily or
+permanently any contributor for other behaviors that they deem inappropriate,
+threatening, offensive, or harmful.
+
+## Scope
+
+This Code of Conduct applies within all project spaces, and it also applies when
+an individual is representing the project or its community in public spaces.
+Examples of representing a project or community include using an official
+project e-mail address, posting via an official social media account, or acting
+as an appointed representative at an online or offline event. Representation of
+a project may be further defined and clarified by project maintainers.
+
+## Enforcement
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be
+reported by contacting the project team at opensource+rubocop@github.com. All
+complaints will be reviewed and investigated and will result in a response that
+is deemed necessary and appropriate to the circumstances. The project team is
+obligated to maintain confidentiality with regard to the reporter of an incident.
+Further details of specific enforcement policies may be posted separately.
+
+Project maintainers who do not follow or enforce the Code of Conduct in good
+faith may face temporary or permanent repercussions as determined by other
+members of the project's leadership.
+
+## Attribution
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
+available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.html
+
+[homepage]: https://www.contributor-covenant.org
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index d180481..4f1f09d 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -1,13 +1,42 @@
 # Contributing
 
-## Releasing a new version
+We welcome your contributions to the project. Thank you!
+
+Please note that this project is released with a [Contributor Code of Conduct](CODE_OF_CONDUCT.md). By participating in this project you agree to abide by its terms.
+
+
+## What to contribute
+
+This repository, `rubocop-github` is part of a broader RuboCop ecosystem.
+
+If the Cop you would like to propose is **generally applicable outside of GitHub**:
+
+1. Propose the change upstream in the core open source project (e.g. [`rubocop`](https://github.com/rubocop/rubocop), or [`rubocop-rails`](https://github.com/rubocop/rubocop-rails)), where it will have maximal visibility and discussion/feedback.
+1. Patch the change provisionally into GitHub's project(s), for immediate benefit; that can include this repository.
+1. ...if the proposal is accepted, remove the patch and pull the updated upstream.
+1. ...if the proposal is not accepted, we usually learn something about our proposal, and we then choose whether to maintain the patch ourselves, discard it, or identify a better open-source home for it.
+
+If the Cop is **only applicable for GitHub**, then this is the right place to propose it.
+
+## How to contribute a Pull Request
+
+1. Fork and clone the repository
+1. [Build it and make sure the tests pass](README.md#Testing) on your machine
+1. Create a new branch: `git checkout -b my-branch-name`
+1. Make your change, add tests, and make sure the tests still pass
+1. Push to your fork and submit a Pull Request
+1. Pat yourself on the back and wait for your pull request to be reviewed and merged.
+
+## For Maintainers
+
+### Releasing a new version
 
 1. Update `rubocop-github.gemspec` with the next version number
-2. Update the `CHANGELOG` with changes and contributor
-3. Run `bundle` to update gem version contained in the lockfile
-4. Make a commit: `Release v{VERSION}`
-5. Tag the commit : `git tag v{VERSION}`
-6. Create the package: `gem build rubocop-github.gemspec`
-7.  Push to GitHub: `git push origin && git push origin --tags`
-8. Push to Rubygems: `gem push rubocop-github-{VERSION}.gem`
-9. Publish a new release on GitHub: https://github.com/github/rubocop-github/releases/new
+1. Update the `CHANGELOG` with changes and contributor
+1. Run `bundle` to update gem version contained in the lockfile
+1. Make a commit: `Release v{VERSION}`
+1. Tag the commit : `git tag v{VERSION}`
+1. Create the package: `gem build rubocop-github.gemspec`
+1. Push to GitHub: `git push origin && git push origin --tags`
+1. Push to Rubygems: `gem push rubocop-github-{VERSION}.gem`
+1. Publish a new release on GitHub: https://github.com/github/rubocop-github/releases/new
diff --git a/README.md b/README.md
index 8796a67..16b7a15 100644
--- a/README.md
+++ b/README.md
@@ -1,6 +1,6 @@
 # RuboCop GitHub ![CI](https://github.com/github/rubocop-github/workflows/CI/badge.svg?event=push)
 
-This repository provides recommended RuboCop configuration and additional Cops for use on GitHub open source and internal Ruby projects.
+This repository provides recommended RuboCop configuration and additional Cops for use on GitHub's open source and internal Ruby projects.
 
 ## Usage
 

From 27c926dab95dc989da9e234f169a92142b33e270 Mon Sep 17 00:00:00 2001
From: "Ben Sheldon [he/him]" <bensheldon@github.com>
Date: Thu, 13 Oct 2022 14:04:25 -0700
Subject: [PATCH 04/11] Update CODEOWNERS

---
 CODEOWNERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CODEOWNERS b/CODEOWNERS
index 6e12c3b..fb48a77 100644
--- a/CODEOWNERS
+++ b/CODEOWNERS
@@ -1 +1 @@
-* @github/ruby-archiecture-reviewers
+* @github/ruby-architecture-reviewers

From 25a3a08f7ac3aed0216a755e104e9fdbadd9bac5 Mon Sep 17 00:00:00 2001
From: Issy Long <issyl0@github.com>
Date: Fri, 21 Oct 2022 14:19:04 +0000
Subject: [PATCH 05/11] config/default: Remove some redundant `Enabled: true`
 for cops

- For cops with a styleguide link, where there's evidence that we want
  the rule to apply, we don't need to also explicitly declare
  `Enabled: true` for each of them. Since we removed `DisabledByDefault`,
  the enablements here for cops that are *enabled by default in RuboCop
  itself** are redundant.
- I could have gone further and removed the rules that RuboCop has
  enabled by default that _didn't_ have a styleguide link, but I feel
  like we need some evidence for why a rule is in place first for when
  people come looking at this gem's config to figure out why new rules
  are suddenly failing or not.
---
 config/default.yml | 18 +++---------------
 1 file changed, 3 insertions(+), 15 deletions(-)

diff --git a/config/default.yml b/config/default.yml
index d7883ce..6ae3054 100644
--- a/config/default.yml
+++ b/config/default.yml
@@ -182,16 +182,14 @@ Layout/HeredocIndentation:
   Enabled: false
 
 Layout/IndentationConsistency:
-  Enabled: false
+  StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#indentation
 
 Layout/IndentationStyle:
-  Enabled: true
   EnforcedStyle: spaces
   IndentationWidth: 2
   StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#default-indentation
 
 Layout/IndentationWidth:
-  Enabled: true
   Width: 2
   StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#default-indentation
 
@@ -262,11 +260,9 @@ Layout/SingleLineBlockChain:
   Enabled: false
 
 Layout/SpaceAfterColon:
-  Enabled: true
   StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#spaces-operators
 
 Layout/SpaceAfterComma:
-  Enabled: true
   StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#spaces-operators
 
 Layout/SpaceAfterMethodName:
@@ -276,18 +272,16 @@ Layout/SpaceAfterNot:
   Enabled: true
 
 Layout/SpaceAfterSemicolon:
-  Enabled: true
   StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#spaces-operators
 
 Layout/SpaceAroundBlockParameters:
   Enabled: true
 
 Layout/SpaceAroundEqualsInParameterDefault:
-  Enabled: true
   StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#spaces-around-equals
 
 Layout/SpaceAroundKeyword:
-  Enabled: false
+  StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#spaces-operators
 
 Layout/SpaceAroundMethodCallOperator:
   Enabled: false
@@ -317,7 +311,6 @@ Layout/SpaceInLambdaLiteral:
   Enabled: false
 
 Layout/SpaceInsideArrayLiteralBrackets:
-  Enabled: true
   EnforcedStyle: no_space
   StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#no-spaces-braces
 
@@ -349,7 +342,6 @@ Layout/TrailingEmptyLines:
   Enabled: true
 
 Layout/TrailingWhitespace:
-  Enabled: true
   StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#trailing-whitespace
 
 Lint/AmbiguousAssignment:
@@ -1090,7 +1082,6 @@ Style/DateTime:
   Enabled: false
 
 Style/DefWithParentheses:
-  Enabled: true
   StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#method-parens-when-arguments
 
 Style/Dir:
@@ -1178,7 +1169,6 @@ Style/FloatDivision:
   Enabled: false
 
 Style/For:
-  Enabled: true
   StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#avoid-for
 
 Style/FormatString:
@@ -1215,7 +1205,6 @@ Style/HashLikeCase:
   Enabled: false
 
 Style/HashSyntax:
-  Enabled: true
   EnforcedStyle: ruby19_no_mixed_keys
   StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#symbols-as-keys
 
@@ -1316,7 +1305,6 @@ Style/MultilineIfModifier:
   Enabled: false
 
 Style/MultilineIfThen:
-  Enabled: true
   StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#no-then-for-multi-line-if-unless
 
 Style/MultilineInPatternThen:
@@ -1583,8 +1571,8 @@ Style/StringHashKeys:
   Enabled: false
 
 Style/StringLiterals:
-  Enabled: true
   EnforcedStyle: double_quotes
+  StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#double-quotes
 
 Style/StringLiteralsInInterpolation:
   Enabled: false

From 217b98638c7636652c1430a19d32c13f97eb7e27 Mon Sep 17 00:00:00 2001
From: Sam Partington <sampart@github.com>
Date: Fri, 21 Oct 2022 16:35:38 +0100
Subject: [PATCH 06/11] Fix Styleguide link in default.yml

https://github.com/github/rubocop-github/pull/124/files#r1000474353
---
 config/default.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/config/default.yml b/config/default.yml
index d7883ce..ad02001 100644
--- a/config/default.yml
+++ b/config/default.yml
@@ -691,7 +691,7 @@ Lint/UnreachableLoop:
 # TODO: Enable this since it's in the styleguide.
 Lint/UnusedBlockArgument:
   Enabled: false
-  StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#spaces-around-equals
+  StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#underscore-unused-vars
 
 Lint/UnusedMethodArgument:
   Enabled: false

From 8e768057435f96782bb53fa91fc7c77f8d857a58 Mon Sep 17 00:00:00 2001
From: Sam Partington <sampart@github.com>
Date: Tue, 25 Oct 2022 13:52:40 +0100
Subject: [PATCH 07/11] Add link to Style Guide from README

---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.md b/README.md
index 8796a67..7ba558f 100644
--- a/README.md
+++ b/README.md
@@ -1,6 +1,6 @@
 # RuboCop GitHub ![CI](https://github.com/github/rubocop-github/workflows/CI/badge.svg?event=push)
 
-This repository provides recommended RuboCop configuration and additional Cops for use on GitHub open source and internal Ruby projects.
+This repository provides recommended RuboCop configuration and additional Cops for use on GitHub open source and internal Ruby projects, and is the home of [GitHub's Ruby Style Guide](./STYLEGUIDE.md).
 
 ## Usage
 

From d24723ec59b2ceae6fd42f62746330841c35e058 Mon Sep 17 00:00:00 2001
From: Sam Partington <sampart@github.com>
Date: Tue, 25 Oct 2022 14:33:09 +0100
Subject: [PATCH 08/11] Add Rails recommendations to styleguide

These were originally in our web-systems documentation
---
 STYLEGUIDE.md | 128 ++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 128 insertions(+)

diff --git a/STYLEGUIDE.md b/STYLEGUIDE.md
index 1e55a3b..5683923 100644
--- a/STYLEGUIDE.md
+++ b/STYLEGUIDE.md
@@ -27,6 +27,9 @@ This is GitHub's Ruby Style Guide, inspired by [RuboCop's guide][rubocop-guide].
     1. [Conditional keywords](#conditional-keywords)
     2. [Ternary operator](#ternary-operator)
 17. [Syntax](#syntax)
+18. [Rails](#rails)
+    1. [content_for](#content_for)
+    2. [Instance Variables in Views](#instance-variables-in-views)
 
 ## Layout
 
@@ -893,4 +896,129 @@ result = hash.map { |_, v| v + 1 }
 
   Refactoring is even better. It's worth looking hard at any code that explicitly checks types.
 
+## Rails
+
+### content_for
+
+Limit usage of `content_for` helper. The use of `content_for` is the same as setting an instance variable plus `capture`.
+
+``` erb
+<% content_for :foo do %>
+  Hello
+<% end %>
+```
+
+Is effectively the same as
+
+``` erb
+<% @foo_content = capture do %>
+  Hello
+<% end %>
+```
+
+See "Instance Variables in Views" below.
+
+#### Common Anti-patterns
+
+**Using `content_for` within the same template to capture data.**
+
+Instead, just use `capture`.
+
+``` erb
+<!-- bad -->
+<% content_for :page do %>
+  Hello
+<% end %>
+<% if foo? %>
+  <div class="container">
+    <%= yield :page %>
+  </div>
+<% else %>
+  <%= yield :page %>
+<% end %>
+```
+
+Simply capture and use a local variable since the result is only needed in this template.
+
+``` erb
+<!-- good -->
+<% page = capture do %>
+  Hello
+<% end %>
+<% if foo? %>
+  <div class="container">
+    <%= page %>
+  </div>
+<% else %>
+  <%= page %>
+<% end %>
+```
+
+**Using `content_for` to pass content to a subtemplate.**
+
+Instead, `render layout:` with a block.
+
+``` erb
+<!-- bad -->
+<% content_for :page do %>
+  Hello
+<% end %>
+<%= render partial: "page" %>
+<!-- _page.html.erb -->
+<div class="container">
+  <%= yield :page %>
+</div>
+```
+
+Pass the content in a block directly to the `render` function.
+
+``` erb
+<!-- good -->
+<%= render layout: "page" do %>
+  Hello
+<% end %>
+<!-- _page.html.erb -->
+<div class="container">
+  <%= yield %>
+</div>
+```
+
+### Instance Variables in Views
+
+In general, passing data between templates with instance variables is discouraged. This even applies from controllers to templates, not just between partials.
+
+`:locals` can be used to pass data from a controller just like partials.
+
+``` ruby
+def show
+  render "blob/show", locals: {
+    :repository => current_repository,
+    :commit     => current_commit,
+    :blob       => current_blob
+  }
+end
+```
+
+Rails implicit renders are also discouraged.
+
+Always explicitly render templates with a full directory path. This makes template callers easier to trace. You can find all the callers of `"app/view/site/hompage.html.erb"` with a simple project search for `"site/homepage"`.
+
+``` ruby
+def homepage
+  render "site/homepage"
+end
+```
+
+#### Exceptions
+
+There are some known edge cases where you might be forced to use instance variables. In these cases, its okay to do so.
+
+##### Legacy templates
+
+If you need to call a subview that expects an instance variable be set. If possible consider refactoring the subview to accept a local instead.
+
+##### Layouts
+
+Unfortunately the only way to get data into a layout template is with instance variables. You can't explicitly pass locals to them.
+
 [rubocop-guide]: https://github.com/rubocop-hq/ruby-style-guide

From 9930c9050c0fd314ea291b8b08e7d7cd01dcef87 Mon Sep 17 00:00:00 2001
From: "Ben Sheldon [he/him]" <bensheldon@github.com>
Date: Wed, 26 Oct 2022 08:02:11 -0700
Subject: [PATCH 09/11] Update CONTRIBUTING.md

Co-authored-by: Sam Partington <sampart@github.com>
---
 CONTRIBUTING.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 4f1f09d..a69b7d2 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -7,7 +7,7 @@ Please note that this project is released with a [Contributor Code of Conduct](C
 
 ## What to contribute
 
-This repository, `rubocop-github` is part of a broader RuboCop ecosystem.
+This repository, `rubocop-github`, is part of a broader RuboCop ecosystem.
 
 If the Cop you would like to propose is **generally applicable outside of GitHub**:
 

From ffeb9fbdc9003f0d125573d2fbb9079df50228c7 Mon Sep 17 00:00:00 2001
From: Issy Long <issyl0@github.com>
Date: Wed, 26 Oct 2022 15:30:43 +0000
Subject: [PATCH 10/11] STYLEGUIDE: For each styleguide recommendation, link to
 the RuboCop rule

- This allows people who are reading the style guide to investigate the
  configuration of the RuboCop rules in their apps if they wish, without
  having to Google the words in our styleguide which might not match the
  RuboCop rule explanation, and guess as to what the cop is called.

Co-authored-by: Issy Long <issyl0@github.com>
Co-authored-by: Elena Tanasoiu <elenatanasoiu@github.com>
---
 STYLEGUIDE.md | 66 +++++++++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 62 insertions(+), 4 deletions(-)

diff --git a/STYLEGUIDE.md b/STYLEGUIDE.md
index 1e55a3b..476fcc0 100644
--- a/STYLEGUIDE.md
+++ b/STYLEGUIDE.md
@@ -34,9 +34,11 @@ This is GitHub's Ruby Style Guide, inspired by [RuboCop's guide][rubocop-guide].
 
 * Use soft-tabs with a two space indent.
   <a name="default-indentation"></a><sup>[[link](#default-indentation)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_layout.html#layoutindentationstyle">RuboCop rule: Layout/IndentationStyle</a>
 
 * Indent `when` with the start of the `case` expression.
   <a name="indent-when-as-start-of-case"></a><sup>[[link](#indent-when-as-start-of-case)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_layout.html#layoutcaseindentation">RuboCop rule: Layout/CaseIndentation</a>
 
 ``` ruby
 # bad
@@ -80,10 +82,18 @@ end
 
 * Never leave trailing whitespace.
   <a name="trailing-whitespace"></a><sup>[[link](#trailing-whitespace)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_layout.html#layouttrailingwhitespace">RuboCop rule: Layout/TrailingWhitespace</a>
 
 * Use spaces around operators, after commas, colons and semicolons, around `{`
   and before `}`.
   <a name="spaces-operators"></a><sup>[[link](#spaces-operators)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_layout.html#layoutspacearoundoperators">RuboCop rule: Layout/SpaceAroundOperators</a>
+  * <a href="https://docs.rubocop.org/rubocop/cops_layout.html#layoutspaceaftercomma">RuboCop rule: Layout/SpaceAfterComma</a>
+  * <a href="https://docs.rubocop.org/rubocop/cops_layout.html#layoutspaceaftercolon">RuboCop rule: Layout/SpaceAfterColon</a>
+  * <a href="https://docs.rubocop.org/rubocop/cops_layout.html#layoutspacebeforeblockbraces">RuboCop rule: Layout/SpaceBeforeBlockBraces</a>
+  * <a href="https://docs.rubocop.org/rubocop/cops_layout.html#layoutspaceinsidehashliteralbraces">RuboCop rule: Layout/SpaceInsideHashLiteralBraces</a>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#stylehashsyntax">RuboCop rule: Style/HashSyntax</a>
+  * <a href="https://docs.rubocop.org/rubocop/cops_layout.html#layoutspacearoundoperators">RuboCop rule: Layout/SpaceAroundOperators</a>
 
 ``` ruby
 sum = 1 + 2
@@ -94,6 +104,8 @@ a, b = 1, 2
 
 * No spaces after `(`, `[` or before `]`, `)`.
   <a name="no-spaces-braces"></a><sup>[[link](#no-spaces-braces)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_layout.html#layoutspaceinsideparens">RuboCop rule: Layout/SpaceInsideParens</a>
+  * <a href="https://docs.rubocop.org/rubocop/cops_layout.html#layoutspaceinsidereferencebrackets">RuboCop rule: Layout/SpaceInsideReferenceBrackets</a>
 
 ``` ruby
 some(arg).other
@@ -102,6 +114,7 @@ some(arg).other
 
 * No spaces after `!`.
   <a name="no-spaces-bang"></a><sup>[[link](#no-spaces-bang)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_layout.html#layoutspaceafternot">RuboCop rule: Layout/SpaceAfterNot</a>
 
 ``` ruby
 !array.include?(element)
@@ -111,10 +124,12 @@ some(arg).other
 
 * End each file with a [newline](https://github.com/bbatsov/ruby-style-guide#newline-eof).
   <a name="newline-eof"></a><sup>[[link](#newline-eof)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_layout.html#layouttrailingemptylines">RuboCop rule: Layout/TrailingEmptyLines</a>
 
 * Use empty lines between `def`s and to break up a method into logical
   paragraphs.
   <a name="empty-lines-def"></a><sup>[[link](#empty-lines-def)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_layout.html#layoutemptylinebetweendefs">RuboCop rule: Layout/EmptyLineBetweenDefs</a>
 
 ``` ruby
 def some_method
@@ -134,12 +149,14 @@ end
 
 * Keep each line of code to a readable length. Unless you have a reason to, keep lines to a maximum of 118 characters. Why 118? That's the width at which the pull request diff UI needs horizontal scrolling (making pull requests harder to review).
   <a name="line-length"></a><sup>[[link](#line-length)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_layout.html#layoutlinelength">RuboCop rule: Layout/LineLength</a>
 
 ## Classes
 
 * Avoid the usage of class (`@@`) variables due to their unusual behavior
 in inheritance.
   <a name="class-variables"></a><sup>[[link](#class-variables)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#styleclassvars">RuboCop rule: Style/ClassVars</a>
 
 ``` ruby
 class Parent
@@ -164,6 +181,7 @@ Parent.print_class_var # => will print "child"
 * Use `def self.method` to define singleton methods. This makes the methods
   more resistant to refactoring changes.
   <a name="singleton-methods"></a><sup>[[link](#singleton-methods)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#styleclassmethodsdefinitions">RuboCop rule: Style/ClassMethodsDefinitions</a>
 
 ``` ruby
 class TestClass
@@ -181,6 +199,7 @@ class TestClass
 * Avoid `class << self` except when necessary, e.g. single accessors and aliased
   attributes.
   <a name="class-method-definitions"></a><sup>[[link](#class-method-definitions)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#styleclassmethodsdefinitions">RuboCop rule: Style/ClassMethodsDefinitions</a>
 
 ``` ruby
 class TestClass
@@ -214,6 +233,8 @@ end
 * Indent the `public`, `protected`, and `private` methods as much the
   method definitions they apply to. Leave one blank line above them.
   <a name="access-modifier-identation"></a><sup>[[link](#access-modifier-identation)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_layout.html#layoutaccessmodifierindentation">RuboCop rule: Layout/AccessModifierIndentation</a>
+  * <a href="https://docs.rubocop.org/rubocop/cops_layout.html#layoutemptylinesaroundaccessmodifier">RuboCop rule: Layout/EmptyLinesAroundAccessModifier</a>
 
 ``` ruby
 class SomeClass
@@ -231,6 +252,7 @@ end
 * Avoid explicit use of `self` as the recipient of internal class or instance
   messages unless to specify a method shadowed by a variable.
   <a name="self-messages"></a><sup>[[link](#self-messages)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#styleredundantself">RuboCop rule: Style/RedundantSelf</a>
 
 ``` ruby
 class SomeClass
@@ -248,6 +270,7 @@ end
 * Prefer `%w` to the literal array syntax when you need an array of
 strings.
   <a name="percent-w"></a><sup>[[link](#percent-w)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#stylewordarray">RuboCop rule: Style/WordArray</a>
 
 ``` ruby
 # bad
@@ -265,6 +288,7 @@ STATES = %w(draft open closed)
 
 * Use symbols instead of strings as hash keys.
   <a name="symbols-as-keys"></a><sup>[[link](#symbols-as-keys)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#stylestringhashkeys">RuboCop rule: Style/StringHashKeys</a>
 
 ``` ruby
 # bad
@@ -300,9 +324,10 @@ end
 
 Avoid calling `send` and its cousins unless you really need it. Metaprogramming can be extremely powerful, but in most cases you can write code that captures your meaning by being explicit:
 <a name="avoid-send"></a><sup>[[link](#avoid-send)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#stylesend">RuboCop rule: Style/Send</a>
 
 ``` ruby
-# avoid 
+# avoid
 unless [:base, :head].include?(base_or_head)
   raise ArgumentError, "base_or_head must be either :base or :head"
 end
@@ -366,6 +391,7 @@ end
 
 Use the Ruby 1.9 syntax for hash literals when all the keys are symbols:
 <a name="symbols-as-hash-keys"></a><sup>[[link](#symbols-as-hash-keys)]</sup>
+* <a href="https://docs.rubocop.org/rubocop/cops_style.html#stylestringhashkeys">RuboCop rule: Style/StringHashKeys</a>
 
 ``` ruby
 # bad
@@ -396,6 +422,7 @@ link_to("Account", controller: "users", action: "show", id: user)
 
 If you have a hash with mixed key types, use the legacy hashrocket style to avoid mixing styles within the same hash:
 <a name="consistent-hash-syntax"></a><sup>[[link](#consistent-hash-syntax)]</sup>
+* <a href="https://docs.rubocop.org/rubocop/cops_style.html#stylehashsyntax">RuboCop rule: Style/HashSyntax</a>
 
 ``` ruby
 
@@ -417,6 +444,7 @@ hsh = {
 
 [Keyword arguments](http://magazine.rubyist.net/?Ruby200SpecialEn-kwarg) are recommended but not required when a method's arguments may otherwise be opaque or non-obvious when called. Additionally, prefer them over the old "Hash as pseudo-named args" style from pre-2.0 ruby.
 <a name="keyword-arguments"></a><sup>[[link](#keyword-arguments)]</sup>
+* <a href="https://docs.rubocop.org/rubocop/cops_style.html#styleoptionalbooleanparameter">RuboCop rule: Style/OptionalBooleanParameter</a>
 
 So instead of this:
 
@@ -444,21 +472,26 @@ remove_member(user, skip_membership_check: true)
 
 * Use `snake_case` for methods and variables.
   <a name="snake-case-methods-vars"></a><sup>[[link](#snake-case-methods-vars)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_naming.html#namingsnakecase">RuboCop rule: Naming/SnakeCase</a>
+  * <a href="https://docs.rubocop.org/rubocop/cops_naming.html#namingvariablename">RuboCop rule: Naming/VariableName</a>
 
 * Use `CamelCase` for classes and modules.  (Keep acronyms like HTTP,
   RFC, XML uppercase.)
   <a name="camelcase-classes-modules"></a><sup>[[link](#camelcase-classes-modules)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_naming.html#namingclassandmodulecamelcase">RuboCop rule: Naming/ClassAndModuleCamelCase</a>
 
 * Use `SCREAMING_SNAKE_CASE` for other constants.
   <a name="screaming-snake-case-constants"></a><sup>[[link](#screaming-snake-case-constants)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_naming.html#namingconstantname">RuboCop rule: Naming/ConstantName</a>
 
 * The names of predicate methods (methods that return a boolean value)
   should end in a question mark. (i.e. `Array#empty?`).
   <a name="bool-methods-qmark"></a><sup>[[link](#bool-methods-qmark)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_naming.html#namingpredicatename">RuboCop rule: Naming/PredicateName</a>
 
 * The names of potentially "dangerous" methods (i.e. methods that modify `self` or the
   arguments, `exit!`, etc.) should end with an exclamation mark. Bang methods
-  should only exist if a non-bang counterpart (method name which does NOT end with !) 
+  should only exist if a non-bang counterpart (method name which does NOT end with !)
   also exists.
   <a name="dangerous-method-bang"></a><sup>[[link](#dangerous-method-bang)]</sup>
 
@@ -466,6 +499,7 @@ remove_member(user, skip_membership_check: true)
 
 * Use `%w` freely.
   <a name="use-percent-w-freely"></a><sup>[[link](#use-percent-w-freely)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#stylewordarray">RuboCop rule: Style/WordArray</a>
 
 ``` ruby
 STATES = %w(draft open closed)
@@ -474,6 +508,7 @@ STATES = %w(draft open closed)
 * Use `%()` for single-line strings which require both interpolation
   and embedded double-quotes. For multi-line strings, prefer heredocs.
   <a name="percent-parens-single-line"></a><sup>[[link](#percent-parens-single-line)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#stylebarepercentliterals">RuboCop rule: Style/BarePercentLiterals</a>
 
 ``` ruby
 # bad (no interpolation needed)
@@ -494,6 +529,7 @@ STATES = %w(draft open closed)
 
 * Use `%r` only for regular expressions matching *more than* one '/' character.
   <a name="percent-r-regular-expressions"></a><sup>[[link](#percent-r-regular-expressions)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#styleregexpliteral">RuboCop rule: Style/RegexpLiteral</a>
 
 ``` ruby
 # bad
@@ -512,7 +548,7 @@ STATES = %w(draft open closed)
 * Avoid using $1-9 as it can be hard to track what they contain. Named groups
   can be used instead.
   <a name="capture-with-named-groups"></a><sup>[[link](#capture-with-named-groups)]</sup>
-
+  * <a href="https://docs.rubocop.org/rubocop/cops_lint.html#mixedregexpcapturetypes">RuboCop rule: Lint/MixedRegexpCaptureTypes</a>
 ``` ruby
 # bad
 /(regexp)/ =~ string
@@ -571,6 +607,7 @@ documentation about the libraries that the current file uses.
 
 * Prefer string interpolation instead of string concatenation:
   <a name="string-interpolation"></a><sup>[[link](#string-interpolation)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#stylestringconcatenation">RuboCop rule: Style/StringConcatenation</a>
 
 ``` ruby
 # bad
@@ -584,6 +621,7 @@ email_with_name = "#{user.name} <#{user.email}>"
   will always work without a delimiter change, and `'` is a lot more
   common than `"` in string literals.
   <a name="double-quotes"></a><sup>[[link](#double-quotes)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#stylestringliterals">RuboCop rule: Style/StringLiterals</a>
 
 ``` ruby
 # bad
@@ -615,6 +653,7 @@ end
 * Use `def` with parentheses when there are arguments. Omit the
   parentheses when the method doesn't accept any arguments.
   <a name="method-parens-when-arguments"></a><sup>[[link](#method-parens-when-arguments)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#styledefwithparentheses">RuboCop rule: Style/DefWithParentheses</a>
 
  ``` ruby
  def some_method
@@ -632,9 +671,11 @@ end
   always use parentheses in the method invocation. For example, write
   `f((3 + 2) + 1)`.
   <a name="parens-no-spaces"></a><sup>[[link](#parens-no-spaces)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#stylemethodcallwithargsparentheses">RuboCop rule: Style/MethodCallWithArgsParentheses</a>
 
 * Never put a space between a method name and the opening parenthesis.
   <a name="no-spaces-method-parens"></a><sup>[[link](#no-spaces-method-parens)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#styleparenthesesasgroupedexpression">RuboCop rule: Style/ParenthesesAsGroupedExpression</a>
 
 ``` ruby
 # bad
@@ -650,6 +691,7 @@ f(3 + 2) + 1
 
 * Never use `then` for multi-line `if/unless`.
   <a name="no-then-for-multi-line-if-unless"></a><sup>[[link](#no-then-for-multi-line-if-unless)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#stylemultilineifthen">RuboCop rule: Style/MultilineIfThen</a>
 
 ``` ruby
 # bad
@@ -665,10 +707,12 @@ end
 
 * The `and` and `or` keywords are banned. It's just not worth it. Always use `&&` and `||` instead.
   <a name="no-and-or-or"></a><sup>[[link](#no-and-or-or)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#styleandor">RuboCop rule: Style/AndOr</a>
 
 * Favor modifier `if/unless` usage when you have a single-line
   body.
   <a name="favor-modifier-if-unless"></a><sup>[[link](#favor-modifier-if-unless)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#stylemultilineternaryoperator">RuboCop rule: Style/MultilineTernaryOperator</a>
 
 ``` ruby
 # bad
@@ -682,6 +726,7 @@ do_something if some_condition
 
 * Never use `unless` with `else`. Rewrite these with the positive case first.
   <a name="no-else-with-unless"></a><sup>[[link](#no-else-with-unless)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#styleunlesselse">RuboCop rule: Style/UnlessElse</a>
 
 ``` ruby
 # bad
@@ -701,6 +746,7 @@ end
 
 * Don't use parentheses around the condition of an `if/unless/while`.
   <a name="no-parens-if-unless-while"></a><sup>[[link](#no-parens-if-unless-while)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#styleparenthesesaroundcondition">RuboCop rule: Style/ParenthesesAroundCondition</a>
 
 ``` ruby
 # bad
@@ -720,6 +766,7 @@ end
   trivial. However, do use the ternary operator(`?:`) over `if/then/else/end` constructs
   for single line conditionals.
   <a name="trivial-ternary"></a><sup>[[link](#trivial-ternary)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#stylemultilineternaryoperator">RuboCop rule: Style/MultilineTernaryOperator</a>
 
 ``` ruby
 # bad
@@ -731,11 +778,13 @@ result = some_condition ? something : something_else
 
 * Avoid multi-line `?:` (the ternary operator), use `if/unless` instead.
   <a name="no-multiline-ternary"></a><sup>[[link](#no-multiline-ternary)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#stylemultilineternaryoperator">RuboCop rule: Style/MultilineTernaryOperator</a>
 
 * Use one expression per branch in a ternary operator. This
   also means that ternary operators must not be nested. Prefer
   `if/else` constructs in these cases.
   <a name="one-expression-per-branch"></a><sup>[[link](#one-expression-per-branch)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#stylenestedternaryoperator">RuboCop rule: Style/NestedTernaryOperator</a>
 
 ``` ruby
 # bad
@@ -757,6 +806,7 @@ end
   doesn't introduce a new scope (unlike `each`) and variables defined
   in its block will be visible outside it.
   <a name="avoid-for"></a><sup>[[link](#avoid-for)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#stylefor">RuboCop rule: Style/For</a>
 
 ``` ruby
 arr = [1, 2, 3]
@@ -776,6 +826,7 @@ arr.each { |elem| puts elem }
   definitions" (e.g. in Rakefiles and certain DSLs).  Avoid `do...end`
   when chaining.
   <a name="squiggly-braces"></a><sup>[[link](#squiggly-braces)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#styleblockdelimiters">RuboCop rule: Style/BlockDelimiters</a>
 
 ``` ruby
 names = ["Bozhidar", "Steve", "Sarah"]
@@ -798,11 +849,12 @@ end.map { |name| name.upcase }
 ```
 
 * Some will argue that multiline chaining would look OK with the use of `{...}`,
- but they should ask themselves: is this code really readable and can't the block's 
+ but they should ask themselves: is this code really readable and can't the block's
  contents be extracted into nifty methods?
 
 * Avoid `return` where not required.
   <a name="avoid-return"></a><sup>[[link](#avoid-return)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#styleredundantreturn">RuboCop rule: Style/RedundantReturn</a>
 
 ``` ruby
 # bad
@@ -818,6 +870,7 @@ end
 
 * Use spaces around the `=` operator when assigning default values to method parameters:
   <a name="spaces-around-equals"></a><sup>[[link](#spaces-around-equals)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#stylespacearoundequalsinparameterdefault">RuboCop rule: Style/SpaceAroundEqualsInParameterDefault</a>
 
 ``` ruby
 # bad
@@ -850,6 +903,7 @@ if (v = next_value) == "hello" ...
 
 * Use `||=` freely to initialize variables.
   <a name="memoization-for-initialization"></a><sup>[[link](#memoize-away)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#styleorassignment">RuboCop rule: Style/OrAssignment</a>
 
 ``` ruby
 # set name to Bozhidar, only if it's nil or false
@@ -859,6 +913,7 @@ name ||= "Bozhidar"
 * Don't use `||=` to initialize boolean variables. (Consider what
   would happen if the current value happened to be `false`.)
   <a name="no-memoization-for-boolean"></a><sup>[[link](#no-memoization-for-boolean)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#styleorassignment">RuboCop rule: Style/OrAssignment</a>
 
 ``` ruby
 # bad - would set enabled to true even if it was false
@@ -873,9 +928,11 @@ enabled = true if enabled.nil?
   one-liner scripts is discouraged. Prefer long form versions such as
   `$PROGRAM_NAME`.
   <a name="no-cryptic-vars"></a><sup>[[link](#no-cryptic-vars)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#stylespecialglobalvars">RuboCop rule: Style/SpecialGlobalVars</a>
 
 * Use `_` for unused block parameters.
   <a name="underscore-unused-vars"></a><sup>[[link](#underscore-unused-vars)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#styleunusedblockargument">RuboCop rule: Style/UnusedBlockArgument</a>
 
 ``` ruby
 # bad
@@ -890,6 +947,7 @@ result = hash.map { |_, v| v + 1 }
   For example, `String === "hi"` is true and `"hi" === String` is false.
   Instead, use `is_a?` or `kind_of?` if you must.
   <a name="type-checking-is-a-kind-of"></a><sup>[[link](#type-checking-is-a-kind-of)]</sup>
+  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#stylecaseequality">RuboCop rule: Style/CaseEquality</a>
 
   Refactoring is even better. It's worth looking hard at any code that explicitly checks types.
 

From 90a607fbb26666eae11b8d2c4253edd85b3e8da8 Mon Sep 17 00:00:00 2001
From: Issy Long <issyl0@github.com>
Date: Thu, 27 Oct 2022 12:16:15 +0100
Subject: [PATCH 11/11] STYLEGUIDE: `UnusedBlockArgument` is in `Lint` not
 `Style`

---
 STYLEGUIDE.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/STYLEGUIDE.md b/STYLEGUIDE.md
index b294075..758651b 100644
--- a/STYLEGUIDE.md
+++ b/STYLEGUIDE.md
@@ -935,7 +935,7 @@ enabled = true if enabled.nil?
 
 * Use `_` for unused block parameters.
   <a name="underscore-unused-vars"></a><sup>[[link](#underscore-unused-vars)]</sup>
-  * <a href="https://docs.rubocop.org/rubocop/cops_style.html#styleunusedblockargument">RuboCop rule: Style/UnusedBlockArgument</a>
+  * <a href="https://docs.rubocop.org/rubocop/cops_lint.html#lintunusedblockargument">RuboCop rule: Lint/UnusedBlockArgument</a>
 
 ``` ruby
 # bad