From a899fa276edf38e3ce20c5c59a61002b697d82f5 Mon Sep 17 00:00:00 2001 From: Issy Long Date: Tue, 11 Oct 2022 16:04:26 +0000 Subject: [PATCH] README, guides: Clean up leftover `GitHub/Accessibility` cop references - My changes in https://github.com/github/rubocop-github/pull/118 didn't quite go far enough. --- README.md | 2 +- guides/image-has-alt.md | 29 ----------------------------- guides/link-has-href.md | 29 ----------------------------- guides/no-positive-tabindex.md | 24 ------------------------ guides/no-redundant-image-alt.md | 24 ------------------------ 5 files changed, 1 insertion(+), 107 deletions(-) delete mode 100644 guides/image-has-alt.md delete mode 100644 guides/link-has-href.md delete mode 100644 guides/no-positive-tabindex.md delete mode 100644 guides/no-redundant-image-alt.md diff --git a/README.md b/README.md index b5fb2ad..da68674 100644 --- a/README.md +++ b/README.md @@ -37,4 +37,4 @@ bundle exec rake test ## The Cops -All cops are located under [`lib/rubocop/cop/github`](lib/rubocop/cop/github) and [`lib/rubocop/cop/github/accessibility`](lib/rubocop/cop/github/accessibility), and contain examples/documentation. +All cops are located under [`lib/rubocop/cop/github`](lib/rubocop/cop/github). diff --git a/guides/image-has-alt.md b/guides/image-has-alt.md deleted file mode 100644 index a761dba..0000000 --- a/guides/image-has-alt.md +++ /dev/null @@ -1,29 +0,0 @@ -# GitHub/Accessibility/ImageHasAlt - -## Rule Details - -Images should have an alt prop with meaningful text or an empty string for decorative images. - -## Resources - -- [W3C WAI Images Tutorial](https://www.w3.org/WAI/tutorials/images/) -- [Primer: Alternative text for images](https://primer.style/design/accessibility/alternative-text-for-images) - -## Examples -### **Incorrect** code for this rule 👎 - -```erb -<%= image_tag "spinners/octocat-spinner-16px.gif", size: "12x12" %> -``` - -### **Correct** code for this rule 👍 - -```erb - -<%= image_tag "spinners/octocat-spinner-16px.gif", size: "12x12", alt: "GitHub Logo spinner" %> -``` - -```erb - -<%= image_tag "spinners/octocat-spinner-16px.gif", size: "12x12", alt: "" %> -``` \ No newline at end of file diff --git a/guides/link-has-href.md b/guides/link-has-href.md deleted file mode 100644 index 8a574c9..0000000 --- a/guides/link-has-href.md +++ /dev/null @@ -1,29 +0,0 @@ -# GitHub/Accessibility/LinkHasHref - -## Rule Details - -Links should go somewhere, you probably want to use a `