From c6dbd4de5b95bf365f92604ddaaadd539b530c33 Mon Sep 17 00:00:00 2001
From: Kate Higa <khiga8@github.com>
Date: Fri, 2 Sep 2022 14:36:48 -0700
Subject: [PATCH 1/3] Remove LinkHasHref

---
 .../link_has_href.rb                          | 23 ------------
 test/test_link_has_href.rb                    | 35 -------------------
 2 files changed, 58 deletions(-)
 delete mode 100644 lib/rubocop/cop/rubocop-rails-accessibility/link_has_href.rb
 delete mode 100644 test/test_link_has_href.rb

diff --git a/lib/rubocop/cop/rubocop-rails-accessibility/link_has_href.rb b/lib/rubocop/cop/rubocop-rails-accessibility/link_has_href.rb
deleted file mode 100644
index 44537d4..0000000
--- a/lib/rubocop/cop/rubocop-rails-accessibility/link_has_href.rb
+++ /dev/null
@@ -1,23 +0,0 @@
-# frozen_string_literal: true
-
-require "rubocop"
-
-module RuboCop
-  module Cop
-    module RubocopRailsAccessibility
-      class LinkHasHref < Base
-        MSG = "Links should go somewhere, you probably want to use a `<button>` instead."
-
-        def on_send(node)
-          receiver, method_name, *args = *node
-
-          return unless receiver.nil? && method_name == :link_to
-
-          return unless args.length == 1 || (args.length > 1 && args[1].type == :str && args[1].children.first == "#")
-
-          add_offense(node.loc.selector)
-        end
-      end
-    end
-  end
-end
diff --git a/test/test_link_has_href.rb b/test/test_link_has_href.rb
deleted file mode 100644
index b62e405..0000000
--- a/test/test_link_has_href.rb
+++ /dev/null
@@ -1,35 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "./cop_test"
-require "minitest/autorun"
-require "rubocop/cop/rubocop-rails-accessibility/link_has_href"
-
-class LinkHasHref < CopTest
-  def cop_class
-    RuboCop::Cop::RubocopRailsAccessibility::LinkHasHref
-  end
-
-  def test_link_has_href_offense
-    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
-      <%= link_to 'Go to GitHub' %>
-    ERB
-
-    assert_equal 1, offenses.count
-    assert_equal "Links should go somewhere, you probably want to use a `<button>` instead.", offenses[0].message
-
-    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
-      <%= link_to 'Go to GitHub', '#' %>
-    ERB
-
-    assert_equal 1, offenses.count
-    assert_equal "Links should go somewhere, you probably want to use a `<button>` instead.", offenses[0].message
-  end
-
-  def test_link_has_href_no_offense
-    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
-      <%= link_to 'Go to GitHub', 'https://github.com/' %>
-    ERB
-
-    assert_equal 0, offenses.count
-  end
-end

From d911c3a11b1455e574932e52897581f83f88853e Mon Sep 17 00:00:00 2001
From: Kate Higa <khiga8@github.com>
Date: Fri, 2 Sep 2022 14:37:02 -0700
Subject: [PATCH 2/3] Remove broken rule for now

---
 config/default.yml      |  3 ---
 guides/link-has-href.md | 29 -----------------------------
 2 files changed, 32 deletions(-)
 delete mode 100644 guides/link-has-href.md

diff --git a/config/default.yml b/config/default.yml
index c5cbbd3..e2b002c 100644
--- a/config/default.yml
+++ b/config/default.yml
@@ -7,9 +7,6 @@ AllCops:
 RubocopRailsAccessibility/ImageHasAlt:
   Enabled: true
   StyleGuide: https://github.com/github/rubocop-rails-accessibility/blob/master/guides/image-has-alt.md
-RubocopRailsAccessibility/LinkHasHref:
-  Enabled: true
-  StyleGuide: https://github.com/github/rubocop-rails-accessibility/blob/master/guides/link-has-href.md
 RubocopRailsAccessibility/NoPositiveTabindex:
   Enabled: true
   StyleGuide: https://github.com/github/rubocop-rails-accessibility/blob/master/guides/no-positive-tabindex.md
diff --git a/guides/link-has-href.md b/guides/link-has-href.md
deleted file mode 100644
index 9ace0e3..0000000
--- a/guides/link-has-href.md
+++ /dev/null
@@ -1,29 +0,0 @@
-# RubocopRailsAccessibility/LinkHasHref
-
-## Rule Details
-
-Links should go somewhere, you probably want to use a `<button>` instead.
-
-## Resources
-
-- [`<a>`: The Anchor element](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a)
-- [Primer: Links](https://primer.style/design/accessibility/links)
-- [HTML Spec: The a element](https://html.spec.whatwg.org/multipage/text-level-semantics.html#the-a-element)
-
-## Examples
-### **Incorrect** code for this rule 👎
-
-```erb
-<%= link_to 'Go to GitHub' %>
-```
-
-```erb
-<%= link_to 'Go to GitHub', '#' %>
-```
-
-### **Correct** code for this rule  👍
-
-```erb
-<!-- good -->
-<%= link_to 'Go to GitHub', 'https://github.com/' %>
-```
\ No newline at end of file

From 689cda2153ecdee2c4d19f5476eb93eec32389cf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adri=C3=A1n=20Bolonio?= <bolonio@github.com>
Date: Wed, 21 Sep 2022 16:58:48 +0200
Subject: [PATCH 3/3] Update README.md

---
 README.md | 1 -
 1 file changed, 1 deletion(-)

diff --git a/README.md b/README.md
index 79c521d..187eea5 100644
--- a/README.md
+++ b/README.md
@@ -53,7 +53,6 @@ examples/documentation.
 ## Rules
 
 - [RuboCop::Cop::Accessibility::ImageHasAlt](guides/image-has-alt.md)
-- [RuboCop::Cop::Accessibility::LinkHasHref](guides/link-has-href.md)
 - [RuboCop::Cop::Accessibility::NoPositiveTabindex](guides/no-positive-tabindex.md)
 - [RuboCop::Cop::Accessibility::NoRedundantImageAlt](guides/no-redundant-image-alt.md)