Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about default config #6

Closed
tubaxenor opened this issue Oct 11, 2022 · 3 comments
Closed

Questions about default config #6

tubaxenor opened this issue Oct 11, 2022 · 3 comments

Comments

@tubaxenor
Copy link

Hi, I would like to know the thinking behind setting AllCops/DisabledByDefult to true here: https://github.com/github/rubocop-rails-accessibility/blob/main/config/default.yml#L4-L5

Since this setting will get merged and override the rubocop default: https://github.com/rubocop/rubocop/blob/master/config/default.yml#L103 I wonder if the gem should turn Enabled flag by cop and not touching AllCops settings?

@bensheldon
Copy link
Collaborator

@tubaxenor thank you for opening up the issue! I think you're correct and it has been removed in #7.

As background, we're doing some cleaning up and re-aligning of this repository and github/rubocop-github and I think that setting got copied over inadvertently (though we're also removing it from rubocop-github too).

@bolonio
Copy link

bolonio commented Nov 7, 2022

Hi @tubaxenor, could you please check if the changes done in the following PR solved the issue you opened, so we can close this issue. Thanks :)

@tubaxenor
Copy link
Author

Yes, it's fixed, thanks 🙏

@bolonio bolonio closed this as completed Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants