-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Questions about default config #6
Comments
@tubaxenor thank you for opening up the issue! I think you're correct and it has been removed in #7. As background, we're doing some cleaning up and re-aligning of this repository and |
Hi @tubaxenor, could you please check if the changes done in the following PR solved the issue you opened, so we can close this issue. Thanks :) |
Yes, it's fixed, thanks 🙏 |
Hi, I would like to know the thinking behind setting
AllCops/DisabledByDefult
totrue
here: https://github.com/github/rubocop-rails-accessibility/blob/main/config/default.yml#L4-L5Since this setting will get merged and override the rubocop default: https://github.com/rubocop/rubocop/blob/master/config/default.yml#L103 I wonder if the gem should turn
Enabled
flag by cop and not touchingAllCops
settings?The text was updated successfully, but these errors were encountered: