Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probot Pull Request checks should verify Custom Properties exist #699

Open
scottcarter87 opened this issue Oct 8, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@scottcarter87
Copy link

Problem Description

When creating a configuration file for a sub-org or repo you are able to define custom properties that you would like to set on the repo. Currently you are able to define custom property names that do not exist in the org which results in nothing happening when the PR is merged.

What is actually happening

When a PR is raised the probot checks the changes and shows that that the custom properties will be added to the repo however when the PR is merged the custom properties never get set because they do not exist at the org level.

Screenshot 2024-10-08 at 9 29 30 AM

What is the expected behavior

The expected behavior would be that the check in the PR fails with an error if either the property name or its value are not valid. The custom property may not exist or in the case of a single or multi-select custom property the value selected is not one of the options that were defined for the custom property.

Error output, if available

n/a

Context

Are you using the hosted instance of probot/settings or running your own?

Running our own using AWS lambda function and API gateway

If running your own instance, are you using it with github.com or GitHub Enterprise?

GitHub.com

Version of probot/settings

2.1.14-rc.1

Version of GitHub Enterprise

n/a

@scottcarter87 scottcarter87 added the bug Something isn't working label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant