Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect optimization #23

Open
GoogleCodeExporter opened this issue May 28, 2015 · 0 comments
Open

Incorrect optimization #23

GoogleCodeExporter opened this issue May 28, 2015 · 0 comments

Comments

@GoogleCodeExporter
Copy link

Sometimes, a search will fail to bring up otherwise valid results because of 
this optimization in geomodel.py (async branch):

      # Stop the search if the next closest possible search result is farther
      # than max_distance or, if we have max_results results already, farther
      # than the last result.

this optimization is correct, but evaluated after expanding cur_geocells, which 
means that the algorithm wrongly assumes that any additional results are 
farther away than the new expanded cur_geocells and not just farther away than 
the already searched cur_geocells. See attached patch for possible fix, which 
moves the expansion logic below the optimizations.

Original issue reported on code.google.com by [email protected] on 25 Aug 2010 at 11:34

Attachments:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant