Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid hard-coded IFLA_LINKINFO #5

Open
2 tasks done
gluxon opened this issue Oct 6, 2019 · 5 comments
Open
2 tasks done

Avoid hard-coded IFLA_LINKINFO #5

gluxon opened this issue Oct 6, 2019 · 5 comments

Comments

@gluxon
Copy link
Owner

gluxon commented Oct 6, 2019 •
edited
Loading

wireguard-uapi-rs/src/socket/link_message.rs

Line 14 in 1fdf165

const IFLA_LINKINFO: libc::c_ushort = 18;

  • PR against rust-lang/libc
  • PR against neli
@gluxon
Copy link
Owner Author

gluxon commented Jan 1, 2020

Fixed by 571725f

@gluxon gluxon closed this as completed Jan 1, 2020
@gluxon
Copy link
Owner Author

gluxon commented Jan 1, 2020

Eh, I might keep this open until the neli portion is done. Reopening.

@gluxon gluxon reopened this Jan 1, 2020
@gluxon
Copy link
Owner Author

gluxon commented May 3, 2020

jbaublitz/neli#63
jbaublitz/neli#64

@MagicRB
Copy link

MagicRB commented May 22, 2020

If I'm not missing something, this should get closed

@gluxon
Copy link
Owner Author

gluxon commented May 22, 2020

I PR'ed against neli but the library hasn't released an update yet. I'd like to remove libc::IFLA_LINKINFO in favor of neli::consts::IFLA_LINKINFO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gluxon @MagicRB