Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable setting server option from VS Code when used as extension by Markdown PDF extension #12

Closed
imuni4fun opened this issue Mar 24, 2019 · 2 comments

Comments

@imuni4fun
Copy link

The example shows how to set options from javascript, but this is an awesome extension for VS Code using Markdown PDF extension. It would be great to be able to set a setting for this extension so it could direct to a private PlantUML server. I have to export to HTML, replace all URLs, and then print to PDF at the moment as a work around. In addition, the ability to strip the "/plantuml" from the url would be great. This would allow easy use with plantuml docker images as shown in the following examples:

docker: docker run -d -p 8080:8080 plantuml/plantuml-server:tomcat
currently generated: "http://www.plantuml.com/plantuml/svg/---sensitive---"
desired generated: "http://localhost:8080/svg/---sensitive---"

@FrVaBe
Copy link

FrVaBe commented Jul 17, 2019

I think this issue should be reported to the vscode-markdown-pdf project, because this is the plugin which uses markdown-it-plantuml and needs to support the configuration of the server option which is provided here.

Therefore I opened a corresponding issue there see #139.

@gmunguia
Copy link
Owner

Closed as per the above.

@gmunguia gmunguia mentioned this issue Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants