Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[META] [Genesis] genesis validator #1228

Closed
zivkovicmilos opened this issue Oct 11, 2023 · 1 comment · Fixed by #1259
Closed

[META] [Genesis] genesis validator #1228

zivkovicmilos opened this issue Oct 11, 2023 · 1 comment · Fixed by #1259
Assignees
@zivkovicmilos
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 🌱 feature New update to Gno

Comments

@zivkovicmilos
Copy link
Member

zivkovicmilos commented Oct 11, 2023 •
edited
Loading

Description

Task copied from the master issue: #1203

validator

The validator subcommand should manage validators in the genesis.json.

Flags

  • --genesis-path - the path to the genesis.json

validator add

The validator add subcommand should add a new validator to the genesis.json. The command should fail if the validator already exists in the genesis.json.

Flags

  • --address - the string address of the validator
  • --pub-key - the hex representation of the validator's public key
  • --name - the name of the validator (must be unique)
  • --power - the voting power of the validator

validator remove

The validator remove subcommand should remove a validator from the genesis.json. The command should fail if the validator does not exist in the genesis.json.

Flags

  • --address - the string address of the validator

PR against branch: feat/genesis
@zivkovicmilos zivkovicmilos added help wanted 🌱 feature New update to Gno 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Oct 11, 2023
@zivkovicmilos zivkovicmilos moved this from Backlog to TODO in 🚪🔁 The Portal Loop Oct 11, 2023
@moul moul moved this to 🔵 Not Needed for Launch in 🚀 The Launch [DEPRECATED] Oct 11, 2023
@zivkovicmilos zivkovicmilos moved this from TODO to In Progress in 🚪🔁 The Portal Loop Oct 19, 2023
@zivkovicmilos zivkovicmilos mentioned this issue Oct 19, 2023
Merged
7 tasks
@zivkovicmilos zivkovicmilos self-assigned this Oct 19, 2023
@zivkovicmilos zivkovicmilos linked a pull request Oct 19, 2023 that will close this issue
feat: add genesis validator subcommand #1259
Merged
7 tasks
zivkovicmilos added a commit that referenced this issue Oct 19, 2023
@zivkovicmilos
feat: add genesis validator subcommand (#1259)
347f3c0 
## Description

This PR adds support for the `genesis validator` sub-commands, as
outlined in #1228.

Closes #1228 

Example `genesis validator add` command you can use to test out the
functionality:
```bash
genesis validator add --name milos -pub-key gpub1pgfj7ard9eg82cjtv4u4xetrwqer2dntxyfzxz3pqvknvnspy43c9zp0ts7wgvupldfzkws8kmvvz2eelfmzzupfymwpwzhh9m3 -address g1wpewvuxtyvqqwysndt4f8425tpdg3lf0mhu6fm
```
<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [x] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
@zivkovicmilos
Copy link
Member Author

Closed by #1259

@github-project-automation github-project-automation bot moved this from In Progress to Done in 🚪🔁 The Portal Loop Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zivkovicmilos zivkovicmilos

Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 🌱 feature New update to Gno
Projects
🚀 The Launch [DEPRECATED]
Status: 🔵 Not Needed for Launch
🚪🔁 The Portal Loop
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add genesis validator subcommand zivkovicmilos/gno
1 participant
@zivkovicmilos