Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BFT] Investigate Potential Deadlock in Production Related to EventsSwitch System #1421

Closed
gfanton opened this issue Dec 7, 2023 · 1 comment
Assignees
Labels
🐞 bug Something isn't working

Comments

@gfanton
Copy link
Member

gfanton commented Dec 7, 2023

Following the changes made in PR #1385, which addressed issue #1320, there is a concern that the deadlock observed in BFT tests might also occur in a production environment. PR #1385 introduced a workaround to fix test inconsistencies by using buffered channels in state tests. This solution, while effective for tests, should NOT be use in production.

The original issue involved channels not being fully consumed, leading to deadlocks. While the buffered channels have resolved the deadlock in tests, it's crucial to investigate if this issue could manifest in production scenarios.

@thehowl
Copy link
Member

thehowl commented Dec 21, 2023

Closing this in favour of #1320

@thehowl thehowl closed this as not planned Won't fix, can't repro, duplicate, stale Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
Development

No branches or pull requests

3 participants