You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As the title says, maketx call should be able to do this. I know this might seems like a hassle to develop, so let's have at least 1-level deep structs and slices containing 1-level deep structs & primitives for the v1.
I would like to avoid using maketx run to achieve this functionality, since I see MsgCall used much more on the UI/UX side, where you can simply pack arguments, instead of parsing arguments on the UI side into Gno code and then packing it into MsgRun.
The text was updated successfully, but these errors were encountered:
I want to make something clear: we're not adding support for compound types on this converter (slices, structs, arrays, ...). I've already partly expressed my thoughts on it, but essentially it is a heavy duplication of the parsing work that is already done when parsing an expression within the GnoVM. I'm heavily opposed to making it work for any non-primitive type.
Discussing this in last week's review meeting, this what was me and manfred convened: #1591 (comment)
Of course this is open for further proposals. I see though that this issue and #1600 have a lot in common in terms of what they're trying to achieve.
When we touched on this with Jae some time ago, I recall that he mentioned that using Call should be "extremely safe" and seemed to be resistant to the idea of changing it. In any case, if we want to go in the direction of supporting compound types in Call, then I'll fight tooth and nail to make this work by replacing the current call message (ie. -func Hello -args 1 -args 2) to -expr 'Hello(1, 2)', so we don't have two parsers attempting to achieve the same thing.
Description
As the title says,
maketx call
should be able to do this. I know this might seems like a hassle to develop, so let's have at least 1-level deep structs and slices containing 1-level deep structs & primitives for the v1.I would like to avoid using
maketx run
to achieve this functionality, since I seeMsgCall
used much more on the UI/UX side, where you can simply pack arguments, instead of parsing arguments on the UI side into Gno code and then packing it intoMsgRun
.The text was updated successfully, but these errors were encountered: