Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GnoVM] Deprecate & remove std.CurrentRealmPath() #2045

Closed
leohhhn opened this issue May 6, 2024 · 3 comments · Fixed by #2087
Closed

[GnoVM] Deprecate & remove std.CurrentRealmPath() #2045

leohhhn opened this issue May 6, 2024 · 3 comments · Fixed by #2087
Assignees
@linhpn99
Milestone
🏗4️⃣ test4.gno.land

Comments

@leohhhn
Copy link
Contributor

leohhhn commented May 6, 2024 •
edited
Loading

Description

Deprecate & remove std.CurrentRealmPath() in favor of CurrentRealm().Path(), as suggested here. After removing the function from the stdlibs, also please remove its references from the docs.
@Kouteki Kouteki added this to the 🏗4️⃣ test4.gno.land milestone May 10, 2024
@Kouteki Kouteki moved this from Triage to Todo in 🧙‍♂️gno.land core team May 10, 2024
@linhpn99
Copy link
Contributor

If this PR has not been assigned to anyone, I can do it

@thehowl
Copy link
Member

thehowl commented May 13, 2024

@linhpn99 go ahead!

@linhpn99
Copy link
Contributor

linhpn99 commented May 13, 2024 •
edited by leohhhn
Loading

@linhpn99 go ahead!

@thehowl @leohhhn #2087 please take a look

@linhpn99 linhpn99 mentioned this issue May 13, 2024
Merged
7 tasks
@Kouteki Kouteki linked a pull request May 15, 2024 that will close this issue
feat(stdlibs/std)!: remove std.CurrentRealmPath #2087
Merged
7 tasks
@Kouteki Kouteki moved this from Todo to In Progress in 🧙‍♂️gno.land core team May 15, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in 🧙‍♂️gno.land core team May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linhpn99 linhpn99

Labels
None yet
Projects
🧙‍♂️gno.land core team
Archived in project
Milestone
🏗4️⃣ test4.gno.land
Development

Successfully merging a pull request may close this issue.

feat(stdlibs/std)!: remove std.CurrentRealmPath linhpn99/gno
4 participants
@thehowl @Kouteki @leohhhn @linhpn99