Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Banker should use PrevRealm instead of OrigPkgAddr #986

Closed
thehowl opened this issue Jul 21, 2023 · 3 comments
Closed

Banker should use PrevRealm instead of OrigPkgAddr #986

thehowl opened this issue Jul 21, 2023 · 3 comments
Assignees
@thehowl
Milestone
🏗4️⃣ test4.gno.land

Comments

@thehowl
Copy link
Member

thehowl commented Jul 21, 2023 •
edited
Loading

X_bankerSendCoins currently uses OrigPkgAddr to determine which "bank" to access.

We should make BankerTypeOrigSend only accessible to realms being directly called (ie. PrevRealm().IsUser()), and BankerTypeSend scoped to the m.CurrentRealm().Addr() of who created them.
@thehowl thehowl mentioned this issue Jul 21, 2023
Closed
@michelleellen michelleellen mentioned this issue Jul 26, 2023
Closed
14 tasks
@moul
Copy link
Member

moul commented Jul 27, 2023 •
edited
Loading

Related with #875 (and #393)

@moul moul mentioned this issue Jul 27, 2023
Open
3 tasks
@michelleellen michelleellen mentioned this issue Aug 8, 2023
Closed
16 tasks
@michelleellen michelleellen mentioned this issue Aug 23, 2023
Closed
@moul moul moved this to 🌟 Wanted for Launch in 🚀 The Launch [DEPRECATED] Sep 5, 2023
@moul moul moved this from 🌟 Wanted for Launch to 🚀 Needed for Launch in 🚀 The Launch [DEPRECATED] Sep 5, 2023
@moul moul added this to the 🚀 main.gno.land milestone Sep 6, 2023
@thehowl thehowl mentioned this issue Dec 7, 2023
Merged
7 tasks
@thehowl thehowl changed the title how should the banker returned by std.GetBanker be namespaced? Banker should use PrevRealm instead of OrigPkgAddr May 7, 2024
@thehowl thehowl self-assigned this May 7, 2024
@thehowl
Copy link
Member Author

thehowl commented May 7, 2024

Updated the issue to match the real problem (understood with a bit of good ol' hindsight)

@thehowl
Copy link
Member Author

thehowl commented May 7, 2024

Got confused, this is actually fixed by https://github.com/gnolang/gno/pull/1787/files#diff-7e49714abed60dd5f698bfa4ddf3afd61fc6a56872290e2e635139a7a140639b

@thehowl thehowl closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thehowl thehowl

Labels
None yet
Projects
🚀 The Launch [DEPRECATED]
Status: 🚀 Needed for Launch
🧙‍♂️gno.land core team
Archived in project
Milestone
🏗4️⃣ test4.gno.land
Development

No branches or pull requests
2 participants
@moul @thehowl