-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gnovm): gno test
now has gas used information
#2571
Open
thinhnx-var
wants to merge
14
commits into
gnolang:master
Choose a base branch
from
VAR-META-Tech:dev-thinhnx/feat_gno_test_has_gasused
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+54
−28
Open
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
3daba99
feat:gno gno test now has gasused instead of time
thinhnx-var e886543
update
thinhnx-var 01c8eef
update
thinhnx-var b65b347
remove typing err
thinhnx-var 85572a0
Merge branch 'master' into dev-thinhnx/feat_gno_test_has_gasused
thinhnx-var 8e2888d
Merge branch 'master' into dev-thinhnx/feat_gno_test_has_gasused
thinhnx-var 370d3ee
Merge branch 'gnolang:master' into dev-thinhnx/feat_gno_test_has_gasused
thinhnx-var 6c525fc
gofumpted
thinhnx-var ca995ff
refact coding style
thinhnx-var 21cde3f
Merge branch 'master' into dev-thinhnx/feat_gno_test_has_gasused
thinhnx-var 73bf52d
fix linter
thinhnx-var 0cc91ce
fix current testcase expectation with gasUsed information
thinhnx-var 6e31307
re-adding duration of test executing duration
thinhnx-var e90b0d8
Merge branch 'master' into dev-thinhnx/feat_gno_test_has_gasused
thinhnx-var File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't we have both gas used and duration? Both seem useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that people are not often concern about that time so much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll ask in another way -- how do we benefit from removing it? If someone doesn't care about it then they don't have to use it. If someone does care about it then they have it. It's only a few more characters being printed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deelawn
I am fine with keeping the duration to be displayed.
But I have another view, should we move duration to
-print-runtime-metrics
which currently displayingruntime: cycle=%s imports=%d allocs=%s
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before these changes, only subpackage level test execution displayed duration. The runtime metrics are something different. I'm only suggesting that we don't remove existing functionality if there is no good reason to do so. I don't think duration needs to be added anywhere else it doesn't currently exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right 👍 . I re-added the executing duration back again.
The result now looks like this: