feat: initial implementation of grpc #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefft0
reviewed
Sep 11, 2023
|
|
||
| // WithDefaultRemote init a default remote node address. | ||
| var WithDefaultRemote GnomobileOption = func(s *gnomobileService) error { | ||
| s.remote = "testnet.gno.berty.io:26657" |
There was a problem hiding this comment.
What is the difference between this default remote and the one in the Client struct?
https://github.com/gnolang/gnomobile/blob/a07f32725fef3ec12c256445659d00afb81ade2e/service/client.go#L36
jefft0
reviewed
Sep 11, 2023
| remote string | ||
| chainID string | ||
|
|
||
| activeAccount keys.Info |
There was a problem hiding this comment.
Why does the active account need to be maintained in this struct? It seems that this duplicates the functionality of nameOrBech32 in the Client struct.
https://github.com/gnolang/gnomobile/blob/a07f32725fef3ec12c256445659d00afb81ade2e/service/client.go#L23
Signed-off-by: D4ryl00 <[email protected]>
Signed-off-by: D4ryl00 <[email protected]>
Signed-off-by: D4ryl00 <[email protected]>
Signed-off-by: Jeff Thompson <[email protected]>
Signed-off-by: Jeff Thompson <[email protected]>
Signed-off-by: Jeff Thompson <[email protected]>
Signed-off-by: Jeff Thompson <[email protected]>
…be squashed.) Signed-off-by: Jeff Thompson <[email protected]>
Signed-off-by: Jeff Thompson <[email protected]>
Signed-off-by: Jeff Thompson <[email protected]>
Signed-off-by: Jeff Thompson <[email protected]>
Signed-off-by: D4ryl00 <[email protected]>
Signed-off-by: D4ryl00 <[email protected]>
Signed-off-by: D4ryl00 <[email protected]>
D4ryl00
force-pushed
the
feat/add-grpc
branch
from
3101d6f to
0907fef
Compare
Signed-off-by: Jeff Thompson <[email protected]>
chore: Rename gnoland/gnomobile to gnolang/gnomobile
Signed-off-by: D4ryl00 <[email protected]>
Signed-off-by: D4ryl00 <[email protected]>
jefft0
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add rule Makefile to build the protobuf:
make api.generate