Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Open Terminix Here" fails to open MTP/remote location #100

Closed
brunelli opened this issue Feb 23, 2016 · 3 comments
Closed

"Open Terminix Here" fails to open MTP/remote location #100

brunelli opened this issue Feb 23, 2016 · 3 comments
Labels

Comments

@brunelli
Copy link

When you have a sftp or mtp location (probably also other protocols) mounted in Nautilus, opening it and selecting "Open Terminix Here" does nothing.

So I have to open a Terminix instance and cd /run/user/1000/gvfs/$DEVICE. IIRC it used to work with gnome-terminal.

@gnunn1 gnunn1 added the bug label Feb 23, 2016
@gnunn1
Copy link
Owner

gnunn1 commented Feb 23, 2016

Thanks for the report, it also fails if a directory has a space in it.

@gnunn1
Copy link
Owner

gnunn1 commented Feb 23, 2016

I had a quick look at this, there is a couple of issues here. The first is the python extension converts the URI to a directory by stripping off the file:/// portion, of course you need the full URI for anything other then a bog-standard file. The second issue is that terminix may need a way to accept a URI rather then a plain file, more investigation on this part required. I'll look into how gnome-terminal is handling this.

@gnunn1 gnunn1 closed this as completed in e7087dd Feb 23, 2016
@gnunn1
Copy link
Owner

gnunn1 commented Feb 23, 2016

That was surprisingly easy, turns on the gnome-terminal plugin just converts it to a local path. While my python foo is weak, I managed to figure out how to do the same thing in the python code. I tested with my Nexus 6 and confirmed it works, unfortunately I'm working away from home and don't have ready access to a remote server to test that, please try it out and see how it goes.

I noticed the gnome-terminal plugin does some specific handling and parsing for FTP and SSH URIs so more work in that area may be required but I'll wait for a bug report on that first.

I also fixed the issue with spaces in the directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants