Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing profile preferences will change solarized light to dark #128

Closed
liamnoone opened this issue Mar 6, 2016 · 1 comment
Closed
Labels

Comments

@liamnoone
Copy link

When I change the colorscheme to use the Solarized Light built-in colorscheme, then edit the profile's preferences, the colorscheme will automatically change to Solarized Dark.

It happens whether I change it via Preferences -> Profiles, and edit the profile though there, or when I go directly from the profiles list. It also doesn't matter if I close Terminix inbetween changing the profile preferences.

It doesn't happen for all colorschemes; this only seems to happen with Solarized Light. I haven't customized any of the exiting colorschemes, or added any new ones.

I'm running Terminix from AUR with Gnome 3.18.2. It happens with both 0.51.1-1 (current terminix version in aur) and 0.52.1.r0.23a14fa-1 (current terminix-git version in aur) versions.

@gnunn1
Copy link
Owner

gnunn1 commented Mar 7, 2016

Terminix doesn't actually save the color scheme you select, it just saves the colors and then uses a simple matching algorithm to see if the current colors match a pattern and sets the combobox accordingly. Solarized Light and Dark are very similar, likely my matching algorithm has a bug in it.

@gnunn1 gnunn1 added the bug label Mar 7, 2016
@gnunn1 gnunn1 closed this as completed in 3fba938 Mar 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants