Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell processes do not get terminated when closing a session #1409

Closed
f2404 opened this issue May 13, 2018 · 3 comments
Closed

Shell processes do not get terminated when closing a session #1409

f2404 opened this issue May 13, 2018 · 3 comments
Labels

Comments

@f2404
Copy link
Contributor

f2404 commented May 13, 2018

How to reproduce:

  1. Run tilix, verify that it has spawned one shell (e.g. bash) process;
  2. Open another session, verify that there are now 2 shell processes related to Tilix;
  3. Close the second session.
    Expected: The second shell process gets terminated.
    Actual result: It keeps running.

There is no problem with opening and closing terminals within a session, shell processes are terminated in that case.

@f2404 f2404 changed the title Shell processes are not terminated when closing a session Shell processes do not get terminated when closing a session May 13, 2018
@gnunn1
Copy link
Owner

gnunn1 commented May 13, 2018

I force the vte widget to be destroyed so it gets cleaned up however it's possible I missed some combination. I suspect GC would clean it up at some point but it should behave the same everywhere.

BTW is this with tabs or sidebar?

@f2404
Copy link
Contributor Author

f2404 commented May 13, 2018

With terminals, I can see a bash process disappearing immediately after I close a terminal. With sessions, I didn't see bash processes disappearing at all.

This happens with both tabs and sidebar. In sidebar mode, make sure to close a session by using "Close" from the hamburger menu and not by clicking the "x" button which closes its terminal.

@gnunn1 gnunn1 closed this as completed in 49101cb May 14, 2018
@gnunn1
Copy link
Owner

gnunn1 commented May 14, 2018

OK I see the issue, back when GtkD was going through a phase of having issues dealing with some of the more complicated memory management aspects of GTK I had to comment out the explicit destruction of the session. When those issues were corrected I forgot to comment it back in again.

The commit that fixes this simply uncomments the code that was explicitly calling session.destroy. Without this the session never gets GC'ed, I suspect because various event handlers are still tied to it.

@gnunn1 gnunn1 added the bug label May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants