You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Run tilix, verify that it has spawned one shell (e.g. bash) process;
Open another session, verify that there are now 2 shell processes related to Tilix;
Close the second session.
Expected: The second shell process gets terminated.
Actual result: It keeps running.
There is no problem with opening and closing terminals within a session, shell processes are terminated in that case.
The text was updated successfully, but these errors were encountered:
f2404
changed the title
Shell processes are not terminated when closing a session
Shell processes do not get terminated when closing a session
May 13, 2018
I force the vte widget to be destroyed so it gets cleaned up however it's possible I missed some combination. I suspect GC would clean it up at some point but it should behave the same everywhere.
With terminals, I can see a bash process disappearing immediately after I close a terminal. With sessions, I didn't see bash processes disappearing at all.
This happens with both tabs and sidebar. In sidebar mode, make sure to close a session by using "Close" from the hamburger menu and not by clicking the "x" button which closes its terminal.
OK I see the issue, back when GtkD was going through a phase of having issues dealing with some of the more complicated memory management aspects of GTK I had to comment out the explicit destruction of the session. When those issues were corrected I forgot to comment it back in again.
The commit that fixes this simply uncomments the code that was explicitly calling session.destroy. Without this the session never gets GC'ed, I suspect because various event handlers are still tied to it.
How to reproduce:
Expected: The second shell process gets terminated.
Actual result: It keeps running.
There is no problem with opening and closing terminals within a session, shell processes are terminated in that case.
The text was updated successfully, but these errors were encountered: