Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support an ArrayCypherNode type #25

Open
shiftyp opened this issue Dec 5, 2015 · 2 comments
Open

Support an ArrayCypherNode type #25

shiftyp opened this issue Dec 5, 2015 · 2 comments

Comments

@shiftyp
Copy link

shiftyp commented Dec 5, 2015

With Neo4j you can return a collection of nodes, and to support that in cq would require either an ArrayCypherNode type, or use of the ArrayCypherValue type by modifying the CypherValue type so that it can contain a Node. There's already a CypherNode type in the constants for CypherValue, so I think the latter is possible without breaking the existing API. I think the former is a cleaner solution though. Thoughts?

@shiftyp shiftyp changed the title Support a ArrayCypherNode type Support an ArrayCypherNode type Dec 5, 2015
@freeeve
Copy link
Member

freeeve commented Dec 7, 2015

I'm ok with either solution (or actually, could do both). I sort of stopped short of creating all the different possibilities of things that cypher can generate, because I realized you can do maps of arrays or arrays of arrays in cypher fairly easily. Even in one liners:

RETURN [[1,2],[3]]

@freeeve
Copy link
Member

freeeve commented Dec 7, 2015

So my philosophy will be: if you need it, I will merge a PR that supports it. It's unfortunate we can't handle these more generically, but that's just one of the things about go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants