Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese docs file linting failure in local system. #27098

Closed
puni9869 opened this issue Sep 16, 2023 · 12 comments
Closed

Chinese docs file linting failure in local system. #27098

puni9869 opened this issue Sep 16, 2023 · 12 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/code-linting type/docs This PR mainly updates/creates documentation type/upstream This is an issue in one of Gitea's dependencies and should be reported there

Comments

@puni9869
Copy link
Member

puni9869 commented Sep 16, 2023

Description

In github action docs linter is fail on chinese docs md files
https://github.com/go-gitea/gitea/actions/runs/6207127102/job/16852056368?pr=27096#step:5:5

Getting error on the local.

make lint-md
npm install --no-save

added 7 packages, and changed 30 packages in 7s
npx markdownlint docs *.md
docs/content/administration/https-support.zh-cn.md:55:277 MD051/link-fragments Link fragments should be valid [Context: "[HTTP 重定向](http重定向)"]
docs/content/administration/https-support.zh-cn.md:97:244 MD051/link-fragments Link fragments should be valid [Context: "[启用内置服务器S 支持](#使用内置服务器)"]
docs/content/installation/from-source.zh-cn.md:38:67 MD051/link-fragments Link fragments should be valid [Context: "[构建](#构建)"]
docs/content/installation/from-source.zh-tw.md:31:59 MD051/link-fragments Link fragments should be valid [Context: "[編譯章節](#編譯)"]
docs/content/usage/actions/act-runner.zh-cn.md:244:78 MD051/link-fragments Link fragments should be valid [Context: "[配置教程](#配置)"]
make: *** [lint-md] Error 1

I can't fix this due to language barriers.

Gitea Version

0818e9b

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Localhost

Database

PostgreSQL

@puni9869 puni9869 added type/bug type/docs This PR mainly updates/creates documentation topic/code-linting and removed type/bug labels Sep 16, 2023
@lunny
Copy link
Member

lunny commented Sep 16, 2023

I cannot reproduce it.

@CaiCandong CaiCandong added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Sep 16, 2023
@puni9869
Copy link
Member Author

@CaiCandong
Copy link
Member

demo.mp4

@puni9869
Copy link
Member Author

puni9869 commented Sep 16, 2023

@CaiCandong could you take it forward?

@CaiCandong CaiCandong self-assigned this Sep 16, 2023
@silverwind
Copy link
Member

Seems #27094 brought this up, I will do a tweak to actions config so all jobs run when when dependencies change.

@silverwind
Copy link
Member

We could either downgrade markdownlint-cli or fix the links.

@CaiCandong
Copy link
Member

There's nothing wrong with this Markdown , a quicker way is to switch its title to English.

@puni9869
Copy link
Member Author

But this is Chinese language translation, Cannot afford to change the title.

@silverwind
Copy link
Member

There's nothing wrong with this Markdown , a quicker way is to switch its title to English.

Can you report it to https://github.com/DavidAnson/markdownlint?

@silverwind
Copy link
Member

#27100 includes the downgrade of markdownlint-cli as a short-term fix.

@CaiCandong
Copy link
Member

CaiCandong commented Sep 16, 2023

Can you report it to DavidAnson/markdownlint?

I'm sorry, I speak Chinese but am unfamiliar with JS.

@silverwind
Copy link
Member

silverwind commented Sep 16, 2023

Found the issue: DavidAnson/markdownlint#954. So if we upgrade to v0.31.1, it might be fixed, but we need to wait on next release of markdownlint-cli.

@silverwind silverwind added the type/upstream This is an issue in one of Gitea's dependencies and should be reported there label Sep 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/code-linting type/docs This PR mainly updates/creates documentation type/upstream This is an issue in one of Gitea's dependencies and should be reported there
Projects
None yet
Development

No branches or pull requests

4 participants