Fix SQL Server dialect name to match switch case, update failing SQL Server tests #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jinzhu whenever you find time, please review this PR, this would be crucial to run SQL Server tests in local machine as well as in Github Actions. Thank you! 😇 Update: Since |
|
Github Actions SQL Server workflows have been fixed in this commit, the fix is same as this Gorm PR. |
|
Thank you for your review @jinzhu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
Closes #269. Also fixes failing tests for SQL Server (these seem to have never been run previously due to incorrect dialect name, for example see this workflow).
User Case Description
Use correct dialect name when running SQL Server tests, so the tests for
sqlserverare executed.