Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ebooks are always generated with the same content uuid #678

Closed
fmartingr opened this issue Jul 27, 2023 · 4 comments · Fixed by #679
Closed

Ebooks are always generated with the same content uuid #678

fmartingr opened this issue Jul 27, 2023 · 4 comments · Fixed by #679
Assignees
Labels
feature:ebooks type:bug Something isn't working
Milestone

Comments

@fmartingr
Copy link
Member

fmartingr commented Jul 27, 2023

Data

  • Shiori version: Latest master as of today: faa1ae9
  • Database Engine: N/A
  • Operating system: N/A
  • CLI/Web interface/Web Extension: CLI/Web

Describe the bug / actual behavior

Ebooks use the same UUID: https://github.com/go-shiori/shiori/blob/master/internal/core/ebook.go#L152

Expected behavior

Research the field and provide an adequate value.

@fmartingr fmartingr added the type:bug Something isn't working label Jul 27, 2023
@Monirzadeh
Copy link
Collaborator

Monirzadeh commented Jul 27, 2023

Thanks, I will fix that soon.
is it create any specific issue on any device?

@fmartingr
Copy link
Member Author

Thanks, I will fix that soon.
is it create any specific issue on any device?

Honestly I don't know of specifics, but maybe some readers will replace books with the same UUID? I haven't made any research into that. Should the UUID be created from the file contents?

@Monirzadeh
Copy link
Collaborator

UUID in this case is something similar, ISBN (not exactly just similar). It should start with alphabet and some other rule. I'm working on that.

@fmartingr
Copy link
Member Author

UUID in this case is something similar, ISBN (not exactly just similar). It should start with alphabet and some other rule. I'm working on that.

Field type specify it should be uuid: urn:uuid

@fmartingr fmartingr added this to the 1.6.0 milestone Sep 12, 2023
@github-project-automation github-project-automation bot moved this from To do to Done in Roadmap Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:ebooks type:bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants