Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Edit bookmark" window is too small #731

Closed
MageSlayer opened this issue Sep 14, 2023 · 8 comments · Fixed by #732
Closed

"Edit bookmark" window is too small #731

MageSlayer opened this issue Sep 14, 2023 · 8 comments · Fixed by #732
Assignees
Labels
type:enhancement New feature or request

Comments

@MageSlayer
Copy link

Data

  • Shiori version 1.6.0-rc.1 (build 1d52569) at 2023-09-11T17:23:40Z
  • SQLite
  • Devuan x64
  • Web interface

Describe the bug / actual behavior

"Edit bookmark" window is too small. On 4K screen it occupies too little space & can't be expanded.

Expected behavior

Make window be a large percent of browser window or/and allow it to be resizable.

To Reproduce

Just any bookmark.

Screenshots

NA

Notes

NA

@MageSlayer MageSlayer added the type:bug Something isn't working label Sep 14, 2023
@github-project-automation github-project-automation bot moved this to To do in Roadmap Sep 14, 2023
@Monirzadeh
Copy link
Collaborator

Monirzadeh commented Sep 14, 2023

can you add a screenshot?

do you need change in Y and X direction?
something like this

send.mp4

PS: this one not keep remember size yet.

@MageSlayer
Copy link
Author

Screenshot from 2023-09-14 18-00-43

@Monirzadeh
Copy link
Collaborator

Monirzadeh commented Sep 14, 2023 via email

@MageSlayer
Copy link
Author

Yes. I need it as wide as possible.
Something similar to that video.

@fmartingr fmartingr added type:enhancement New feature or request and removed type:bug Something isn't working labels Sep 14, 2023
@fmartingr
Copy link
Member

(screenshot)

This size seems ok to me, CSS should be smart enough to adjust with the <meta name="viewport"> header. I have two screens (one 1080p, other 2k) and it adjust correctly. Also didn't saw any issues with the laptop screen which is HiDPi (almost 4k).

Do you see a problem with the size of the box, the size of the text, or both?

I love the idea of allowing a resizable dialog box (and didn't knew it was that easy!). But we need to account for UX problems like this:
Screenshot 2023-09-15 at 18 12 21

@Monirzadeh
Copy link
Collaborator

you right. is it good enough to change width to the 20% of screen?
it will be around 400px for 1080 and 800px in 4k. for now we have fix width-max 400px in all display.
i should test that on mobile device too.

@MageSlayer
Copy link
Author

Please expand it as wide as possible & make resizable.
Personally I hate UIs made to conform to some abstract artistic choices instead of giving a user the entire hardware capabilities.

@fmartingr
Copy link
Member

you right. is it good enough to change width to the 20% of screen?
it will be around 400px for 1080 and 800px in 4k. for now we have fix width-max 400px in all display.
i should test that on mobile device too.

When I tested it I used 60vw and 70vh as max options for width and height, respective, and it looked good. I think that should be a good compromise for now, not making a big impact on the UI/UX.

@github-project-automation github-project-automation bot moved this from To do to Done in Roadmap Oct 9, 2023
@Monirzadeh Monirzadeh self-assigned this Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants