Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"View Original" link in the archive view references the same page #930

Closed
greenfork opened this issue Jun 5, 2024 · 1 comment · Fixed by #931
Closed

"View Original" link in the archive view references the same page #930

greenfork opened this issue Jun 5, 2024 · 1 comment · Fixed by #931
Assignees
@fmartingr
Labels
type:bug Something isn't working
Milestone
1.7.0

Comments

@greenfork
Copy link

greenfork commented Jun 5, 2024 •
edited
Loading

Data

  • Shiori version: d05188b
  • Database Engine: SQLite
  • Operating system: OpenBSD
  • CLI/Web interface/Web Extension: Web interface

Describe the bug / actual behavior

A link "View Original" on the page like https://links.greenfork.me/bookmark/4/archive references the same https://links.greenfork.me/bookmark/4/archive link.

<body class="archive">
    <div id="shiori-archive-header" class="header">
        <p id="shiori-logo"><span>栞</span>shiori</p>
        <div class="spacer"></div>
        <a href="" target="_blank">View Original</a>
        
        <a href="[/bookmark/4/content](view-source:https://links.greenfork.me/bookmark/4/content)">View Readable</a>
        
    </div>
    <iframe src="[/bookmark/4/archive/file/](view-source:https://links.greenfork.me/bookmark/4/archive/file/)" frameborder="0"></iframe>
</body>

See <a href="" target="_blank">View Original</a>.

Expected behavior

Should be a link to the original resource.

To Reproduce

Steps to reproduce the behavior:

  1. Add a page
  2. Visit its archive
  3. Click "View Original"

Notes

The link to view the original works fine from the home page and from the "readable" page.
@greenfork greenfork added the type:bug Something isn't working label Jun 5, 2024
@github-project-automation github-project-automation bot moved this to To do in Roadmap Jun 5, 2024
@fmartingr
Copy link
Member

Thanks for the report, I reproduced this locally.

@fmartingr fmartingr self-assigned this Jun 5, 2024
@fmartingr fmartingr moved this from To do to In progress in Roadmap Jun 5, 2024
@fmartingr fmartingr added this to the 1.7.0 milestone Jun 5, 2024
@fmartingr fmartingr mentioned this issue Jun 5, 2024
Merged
@github-project-automation github-project-automation bot moved this from In progress to Done in Roadmap Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmartingr fmartingr

Labels
type:bug Something isn't working
Projects
Roadmap
Archived in project
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

fix: incorrect original link in archive page go-shiori/shiori
2 participants
@fmartingr @greenfork