fix: saving bookmarks inconsistencies #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
up until now the SaveBookmarks method was doing some "magic" to do "upserts" on the databases, but consistency between engines was scarce and not knowing if we were expecting saving a new bookmark or updating an existing one was leading to errors and inconsistencies in logic all around the place. Now we need to specify a creation boolean when saving and a differnt query will be make (INSERT vs UPDATE).
Added functions that will share logic among the engines and will be called on fresh databases on each test run
fmartingr
force-pushed
the
fix/database-save
branch
from
1f3b59b
to
135dc13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving bookmarks between engines had some inconsistencies regarding the insert/update mechanism used in shiori, and our latest changes fixing some postgresql issues (Introduced by 222fc14 and dc73cd8 as pointed out in #499) where causing problems in both SQLite and Mysql.
DB.SaveBookmarksmethod, now requires aninsertparameter indicating that we were expecting to create a record.falsewill try to update a record. it would fail either case if the condition is not met.INSERTandUPDATEare split rather than handing conflict onINSERT, since PSQL was handling the URL field, SQLite the ID field and MySQL any failing constraint.