Add securityContext to provided Kubernetes manifest #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #859 +/- ##
=======================================
Coverage 25.58% 25.58%
=======================================
Files 47 47
Lines 5628 5628
=======================================
Hits 1440 1440
Misses 3989 3989
Partials 199 199 ☔ View full report in Codecov by Sentry. |
|
Hey @piano1029, thanks for the contribution. I will probably update the deployment docs with a link to an helm chart instead of having that YAML around, the docs require some love in all areas. Thanks for catching this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the (currently) provided Kubernetes deployment manifest the securityContext is missing, this results in Shiori crashing with a vague "out of memory" error. This pull request adds the securityContext with the same uid and gid values as in the Docker image (1000), fixes #791.