Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): use correct tag names on version bump #864

Merged
merged 2 commits into from
Mar 30, 2024

Conversation

fmartingr
Copy link
Member

@fmartingr fmartingr commented Mar 23, 2024

Use correct tag names when releasing a new version:

  • tag vx.x.x -> vx.x.x & latest
  • tag vx.x.x-rc.x -> vx.x.x-rc.x & dev
  • pr -> pr-xxx

Fixes #863

@fmartingr fmartingr self-assigned this Mar 23, 2024
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.58%. Comparing base (595cb45) to head (9b52bfe).
Report is 5 commits behind head on master.

❗ Current head 9b52bfe differs from pull request most recent head f174b35. Consider uploading reports for the commit f174b35 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #864   +/-   ##
=======================================
  Coverage   25.58%   25.58%           
=======================================
  Files          47       47           
  Lines        5628     5628           
=======================================
  Hits         1440     1440           
  Misses       3989     3989           
  Partials      199      199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Monirzadeh Monirzadeh self-requested a review March 23, 2024 19:44
@Monirzadeh
Copy link
Collaborator

Monirzadeh commented Mar 23, 2024

i test that once again

 podman pull ghcr.io/go-shiori/shiori:latest  

and get this warrning

WARNING: image platform (linux/arm64) does not match the expected platform (linux/amd64)

version is correct but platform not.

@fmartingr
Copy link
Member Author

i test that once again

 podman pull ghcr.io/go-shiori/shiori:latest  

and get this warrning

WARNING: image platform (linux/arm64) does not match the expected platform (linux/amd64)

version is correct but platform not.

Can you try again? it seems I only pushed one arch. All others should be present now.

@Monirzadeh
Copy link
Collaborator

Monirzadeh commented Mar 23, 2024

i test that once again

 podman pull ghcr.io/go-shiori/shiori:latest  

and get this warrning

WARNING: image platform (linux/arm64) does not match the expected platform (linux/amd64)

version is correct but platform not.

Can you try again? it seems I only pushed one arch. All others should be present now.

this time get this. not warning anymore.
Shiori version 1.6.1-next (build 595cb45a2ce7031926ead1f1e1324e673e36d676)
i pull latest that should be 1.6 but get 1.6.1-next

podman pull ghcr.io/go-shiori/shiori:latest

@fmartingr
Copy link
Member Author

i test that once again

 podman pull ghcr.io/go-shiori/shiori:latest  

and get this warrning

WARNING: image platform (linux/arm64) does not match the expected platform (linux/amd64)

version is correct but platform not.

Can you try again? it seems I only pushed one arch. All others should be present now.

this time get this. not warning anymore. Shiori version 1.6.1-next (build 595cb45a2ce7031926ead1f1e1324e673e36d676) i pull latest that should be 1.6 but get 1.6.1-next

podman pull ghcr.io/go-shiori/shiori:latest

Can you confirm now? I still get v1.6.0:

$ docker run --platform=linux/arm64 --rm ghcr.io/go-shiori/shiori:latest version
Unable to find image 'ghcr.io/go-shiori/shiori:latest' locally
latest: Pulling from go-shiori/shiori
bca4290a9639: Already exists 
7482c417b719: Pull complete 
89153048e437: Pull complete 
dfc5ad582dbd: Pull complete 
Digest: sha256:bd195957065cc54541fc576ff47db72e035195ba7c67aace0cf912991eaf7409
Status: Downloaded newer image for ghcr.io/go-shiori/shiori:latest
Shiori version 1.6.0 (build 595cb45a2ce7031926ead1f1e1324e673e36d676) at 2024-03-23T20:35:26Z

Copy link
Collaborator

@Monirzadeh Monirzadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Now it is working correct for me 👍

@fmartingr fmartingr merged commit 47e7259 into master Mar 30, 2024
8 checks passed
@fmartingr fmartingr deleted the ci/release-version-fix branch March 30, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container image tag "latest" is not updated v1.6.0
2 participants