Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: api calls using absolute urls #872

Merged
merged 2 commits into from
Apr 7, 2024
Merged

fix: api calls using absolute urls #872

merged 2 commits into from
Apr 7, 2024

Conversation

fmartingr
Copy link
Member

Some API calls were using an absolute path ignoring the base href element thus not working/pointing where it shouldn't.

Fixes #870

@fmartingr fmartingr self-assigned this Mar 31, 2024
@fmartingr fmartingr changed the title Use relative path for API calls fix: api calls using absolute urls Mar 31, 2024
Copy link
Collaborator

@Monirzadeh Monirzadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
why this should not happen for swagger? endpoint in there start with / too . dose swagger handle that automatically?
can confirm swagger work fine in this situation too?

@fmartingr
Copy link
Member Author

👍 why this should not happen for swagger? endpoint in there start with / too . dose swagger handle that automatically? can confirm swagger work fine in this situation too?

I'm not sure tbh. But let me merge this one and address swagger in a separate one if reported.

@fmartingr fmartingr merged commit ceb392d into master Apr 7, 2024
8 checks passed
@fmartingr fmartingr deleted the fmartingr/issue870 branch April 7, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some API calls do not respect root path
2 participants