Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .goreleaser.yaml #884

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Update .goreleaser.yaml #884

merged 1 commit into from
Apr 13, 2024

Conversation

torculus
Copy link
Contributor

@torculus torculus commented Apr 8, 2024

This addresses #851. I tested with goreleaser and it created the Windows .zip archive, but couldn't publish because I had invalid GITHUB_TOKEN credentials

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.95%. Comparing base (595cb45) to head (cf7765d).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #884      +/-   ##
==========================================
+ Coverage   25.58%   27.95%   +2.36%     
==========================================
  Files          47       47              
  Lines        5628     4096    -1532     
==========================================
- Hits         1440     1145     -295     
+ Misses       3989     2752    -1237     
  Partials      199      199              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fmartingr fmartingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for this and glad to see it was that easy. Sorry that it fell out of my radar.

@fmartingr fmartingr merged commit 394d17b into go-shiori:master Apr 13, 2024
10 checks passed
@Monirzadeh Monirzadeh added this to the 1.6.3 milestone Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants