Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: endpoint to serve readable content #885

Merged
merged 11 commits into from
Apr 20, 2024

Conversation

Monirzadeh
Copy link
Collaborator

@Monirzadeh Monirzadeh commented Apr 8, 2024

this Pull request serve readable content (text only and html) on /api/v1/bookmarks/id/readable

  • serve HTML and text of bookmarks
  • be sure it authenticate correctly
  • fix bug related to send duplicate response if user not authenticate
    bug found wait for fix
  • add unit test

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 30.03%. Comparing base (595cb45) to head (165e3a4).
Report is 18 commits behind head on master.

Files Patch % Lines
internal/http/routes/api/v1/bookmarks.go 89.28% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #885      +/-   ##
==========================================
+ Coverage   25.58%   30.03%   +4.45%     
==========================================
  Files          47       60      +13     
  Lines        5628     4341    -1287     
==========================================
- Hits         1440     1304     -136     
+ Misses       3989     2830    -1159     
- Partials      199      207       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmartingr
Copy link
Member

A fix for the auth middleware: #888

@Monirzadeh Monirzadeh self-assigned this Apr 20, 2024
@Monirzadeh Monirzadeh added this to the 1.6.3 milestone Apr 20, 2024
Copy link
Member

@fmartingr fmartingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how you called the endpoint "readable" instead of "content", we should probably do that in the code as well. I always confused "content" with "archive". Readable is a better name for this.

internal/http/routes/api/v1/bookmarks.go Outdated Show resolved Hide resolved
internal/http/routes/api/v1/bookmarks.go Outdated Show resolved Hide resolved
@fmartingr fmartingr merged commit b8a3578 into go-shiori:master Apr 20, 2024
10 checks passed
@Monirzadeh
Copy link
Collaborator Author

Thanks ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants