-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: endpoint to serve readable content #885
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #885 +/- ##
==========================================
+ Coverage 25.58% 30.03% +4.45%
==========================================
Files 47 60 +13
Lines 5628 4341 -1287
==========================================
- Hits 1440 1304 -136
+ Misses 3989 2830 -1159
- Partials 199 207 +8 ☔ View full report in Codecov by Sentry. |
A fix for the auth middleware: #888 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how you called the endpoint "readable" instead of "content", we should probably do that in the code as well. I always confused "content" with "archive". Readable is a better name for this.
Thanks ❤️ |
this Pull request serve readable content (text only and html) on
/api/v1/bookmarks/id/readable
bug found wait for fix