fix(sqlite): id column should be unique #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #894 +/- ##
==========================================
+ Coverage 25.58% 30.77% +5.19%
==========================================
Files 47 62 +15
Lines 5628 4461 -1167
==========================================
- Hits 1440 1373 -67
+ Misses 3989 2866 -1123
- Partials 199 222 +23 ☔ View full report in Codecov by Sentry. |
fmartingr
approved these changes
May 6, 2024
fmartingr
changed the title
|
i test that in my side and i don't see any problem. |
|
today i thinking about a specific situation. should we handle id that currently reuse in database? |
I don't think so. It already happened and we are avoiding it in the future now. |
fmartingr
added a commit
that referenced
this pull request
May 12, 2024
Co-authored-by: Felipe Martin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR try to fix #892